Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chrome version and fix Slack notification issue #2145

Merged
merged 3 commits into from
May 20, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2133

Let's see if the tests work in the pipeline

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label May 19, 2022
@juans-chainsafe juans-chainsafe self-assigned this May 19, 2022
@render
Copy link

render bot commented May 19, 2022

@render
Copy link

render bot commented May 19, 2022

@render
Copy link

render bot commented May 19, 2022

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@asnaith
Copy link
Member

asnaith commented May 19, 2022

Awesome! Thanks for noticing and fixing the slack notifier so that we see failed jobs too.

I think to trigger the cypress tests you will need to make a temporary change to the app / test code, just modifying the .yml configs is not triggering them.

Then if the cypress tests run and pass you can revert the temp change and we can get this merged :)

@juans-chainsafe
Copy link
Contributor Author

juans-chainsafe commented May 20, 2022

Awesome! Thanks for noticing and fixing the slack notifier so that we see failed jobs too.

I think to trigger the cypress tests you will need to make a temporary change to the app / test code, just modifying the .yml configs is not triggering them.

Then if the cypress tests run and pass you can revert the temp change and we can get this merged :)

Yes! I think I didn't need to change the code, I just run the tests on the demand in this branch and they worked!
https://github.com/ChainSafe/ui-monorepo/actions/runs/2354391205 Storage
https://github.com/ChainSafe/ui-monorepo/actions/runs/2358405233 Files

@Tbaut Tbaut merged commit 5984a6e into dev May 20, 2022
@Tbaut Tbaut deleted the mnt/update-configuration-parameters-for-ui-test-jobs-2133 branch May 20, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update configuration parameters for UI test jobs
5 participants