-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chrome version and fix Slack notification issue #2145
Update Chrome version and fix Slack notification issue #2145
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2145.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca3a8cc6fj3an7tj7300. |
Your Render PR Server URL is https://files-ui-stage-pr-2145.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca3a8dc6fj3an7tj734g. |
Your Render PR Server URL is https://storage-ui-stage-pr-2145.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca3a8ek6fj3an7tj73mg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Awesome! Thanks for noticing and fixing the slack notifier so that we see failed jobs too. I think to trigger the cypress tests you will need to make a temporary change to the app / test code, just modifying the .yml configs is not triggering them. Then if the cypress tests run and pass you can revert the temp change and we can get this merged :) |
Yes! I think I didn't need to change the code, I just run the tests on the demand in this branch and they worked! |
closes #2133
Let's see if the tests work in the pipeline