Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu flash in Firefox #2152

Merged
merged 2 commits into from
May 25, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented May 25, 2022

I was still having issues despite my earlier suggestions, so I refactored a tiny bit and this time I can't reproduce any more.

This PR gets rid of the open/isOpen props and css. Unify the anchorPosition and contextMenuPosition which are the same.

How I could reproduce on Firefox before:

  • refresh the page (with cache clean with ctrl+R)
  • scroll
  • right-click -> the first time it was flashing consistently.

@Tbaut Tbaut requested a review from tanmoyAtb May 25, 2022 12:27
@Tbaut Tbaut mentioned this pull request May 25, 2022
4 tasks
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I don't see any flashes or lag in the menu opening anymore.
I have a feeling this is because of the transition and slight delay in css picking up the position.

This looks to the point, going to merge it in.

@tanmoyAtb tanmoyAtb merged commit 20884e9 into feat/right-click-menu-2095 May 25, 2022
@tanmoyAtb tanmoyAtb deleted the tbaut-context-menu branch May 25, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants