-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-loop-func
lint warning fix
#2157
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2157.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca88u1nh8vlc6bmt3bm0. |
Your Render PR Server URL is https://files-ui-stage-pr-2157.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca88u2vh8vlc6bmt3bqg. |
Your Render PR Server URL is https://storage-ui-stage-pr-2157.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca88u3vh8vlc6bmt3cc0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. I think the original warning doesn't make sense though, the warning acts as if the for
loop wasn't waiting for the encryptAndUpload
to be back, and the uploadedSize
would be out of sync. The reality though is that the for
is actually blocking because of the await, and the uploadedSize
is always in sync.
Regardless, it's always better without any warning. I'd just add a comment for us to remember in the future.
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Absolutely agreed, wanted to ignore the rule in eslint config but decided to let it stay. Might be of use some day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked locally and was fixed, nice!!
We had a eslint warning about an
![Screenshot 2022-05-27 at 2 34 10 PM](https://user-images.githubusercontent.com/10713353/170663631-9a978adc-9b28-4925-99be-66179d9ea965.png)
uploadedSize
variable.This PR fixes the warning.
Alternatively I wanted to ignore the eslint rule. But this works as well 🤷