Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click on shared folder overview ans Storage bucket overview #2168

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 7, 2022

closes #2153

@render
Copy link

render bot commented Jun 7, 2022

@render
Copy link

render bot commented Jun 7, 2022

@render
Copy link

render bot commented Jun 7, 2022

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! the right click is working nice and clean.

I have a suggestion, maybe we can add a toast message when we delete a Shared folder or a Bucket to have the same behaviour that we have in Files in Home

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 7, 2022

yes I realized this as well, when testing, we need to add this. I'll create an issue for this since it's not related.

@Tbaut Tbaut marked this pull request as ready for review June 7, 2022 15:54
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean implementation. working nicely.
Made me realise, we must add a "Confirmation dialogue" on storage before deleting buckets.
Deleting buckets is quite an impactful task.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jun 7, 2022

Hehe yup, that's what Juan was saying, I created an issue :)

@Tbaut Tbaut merged commit fe64a5c into dev Jun 7, 2022
@Tbaut Tbaut deleted the tbaut-right-click-2153 branch June 7, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add right click menu to Shared folder and Bucket overview
3 participants