Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error modal styles #2176

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Error modal styles #2176

merged 2 commits into from
Jun 9, 2022

Conversation

tanmoyAtb
Copy link
Contributor

@tanmoyAtb tanmoyAtb commented Jun 8, 2022

closes #2076

To quickly check the changes,
we can add the error modal component in app.tsx
Here's a piece code to speed things up.

<ErrorModal
  error={new Error("Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.")}
  componentStack={"Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum."}
  eventId='12'
  resetError={() => undefined}
/>

@render
Copy link

render bot commented Jun 8, 2022

@render
Copy link

render bot commented Jun 8, 2022

@render
Copy link

render bot commented Jun 8, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 8, 2022
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the error in a different way and it looks good
image

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nice! when small text there is no scrollbars and when there are bigger texts, the scroll bar is perfect.

@juans-chainsafe juans-chainsafe merged commit 18397eb into dev Jun 9, 2022
@juans-chainsafe juans-chainsafe deleted the fix/error-boundary-2076 branch June 9, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error boundary Styling is broken
3 participants