-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test suite for Cypress 10 #2189
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2189.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cakgrsarrk0crdbv6190. |
Your Render PR Server URL is https://files-ui-stage-pr-2189.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cakgrtirrk0crdbv61l0. |
Your Render PR Server URL is https://storage-ui-stage-pr-2189.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cakgruirrk0crdbv6270. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to review isn't it?
All in all I bet this will be a little more annoying for the QA teams, but as a dev there are only minor changes and the couple more clicks are ok I feel. I hope they'll improve with time but the addition of component tests sounds like a big deal, and they provided a migration path afaiu which is also pretty welcome I guess.
@Tbaut 👍 yep, was just making sure the tests were running in CI as expected. I agree the extra clicking is a minor annoyance for QA during test development but I think this will be improved by the cypress team and isn't something that will affect the dev team/ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional clicks are a little annoying but is fine, they will probably fix it.
Test that are failing are because an error in the API, so not because this PR.
Looks good! thanks for updating it.
closes #2181
I've updated our test suite configuration to Cypress 10 and followed the latest updates/recommendations listed here:
https://docs.cypress.io/guides/references/changelog#10-0-0
Everything is running well, but it's worth noting that more clicks are required when running the cypress UI locally for testing.
Every time you launch with
yarn test:files-ui
you now have to select the type of testing (e2e or component) and then select the browser, it never remembers your choices and there is no configuration option we can set yet (discussed here: Cypress 10 UI less convenient than Cypress 9.x (many more clicks required to do the same thing) cypress-io/cypress#22152).Also, there is no longer a "run all specs" button (discussed here: 'Run all specs' removal in Cypress 10 cypress-io/cypress#21628)