Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite for Cypress 10 #2189

Merged
merged 8 commits into from
Jun 15, 2022
Merged

Update test suite for Cypress 10 #2189

merged 8 commits into from
Jun 15, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Jun 14, 2022

closes #2181


I've updated our test suite configuration to Cypress 10 and followed the latest updates/recommendations listed here:
https://docs.cypress.io/guides/references/changelog#10-0-0

Everything is running well, but it's worth noting that more clicks are required when running the cypress UI locally for testing.

@render
Copy link

render bot commented Jun 14, 2022

@render
Copy link

render bot commented Jun 14, 2022

@render
Copy link

render bot commented Jun 14, 2022

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to review isn't it?
All in all I bet this will be a little more annoying for the QA teams, but as a dev there are only minor changes and the couple more clicks are ok I feel. I hope they'll improve with time but the addition of component tests sounds like a big deal, and they provided a migration path afaiu which is also pretty welcome I guess.

@asnaith
Copy link
Member Author

asnaith commented Jun 15, 2022

This is ready to review isn't it? All in all I bet this will be a little more annoying for the QA teams, but as a dev there are only minor changes and the couple more clicks are ok I feel. I hope they'll improve with time but the addition of component tests sounds like a big deal, and they provided a migration path afaiu which is also pretty welcome I guess.

@Tbaut 👍 yep, was just making sure the tests were running in CI as expected.

I agree the extra clicking is a minor annoyance for QA during test development but I think this will be improved by the cypress team and isn't something that will affect the dev team/ci.

@asnaith asnaith marked this pull request as ready for review June 15, 2022 16:12
@Tbaut Tbaut enabled auto-merge (squash) June 15, 2022 16:22
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional clicks are a little annoying but is fine, they will probably fix it.
Test that are failing are because an error in the API, so not because this PR.
Looks good! thanks for updating it.

@Tbaut Tbaut merged commit 5d72a7c into dev Jun 15, 2022
@Tbaut Tbaut deleted the mnt/bump-cypress-v10-2181 branch June 15, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tests to use Cypress 10
3 participants