-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation position style fixes [storage] #2193
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2193.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cal1ccqrrk0crdbvjlu0. |
Your Render PR Server URL is https://files-ui-stage-pr-2193.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cal1ce2rrk0crdbvjm2g. |
Your Render PR Server URL is https://storage-ui-stage-pr-2193.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cal1cfarrk0crdbvjmk0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanmoyAtb well, yes, make sense to only have those columns in mobile, but just in case I want @asnaith opinion on that to be sure!
👍 I agree with Tanmoy's rationale, it's not worth the time investment in making the view support all columns as are expecting very low usage of Storage UI on mobile devices.
👍 I agree with Tanmoy's rationale, it's not worth the time investment in making the view support all columns as are expecting very low usage of Storage UI on mobile devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, the code is looking good otherwise
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Updates are in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
closes #2087
Submission checklist:
Layout