-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use personal_sign any connected wallet beside the known ones #2211
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2211.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caven1rru51tqnfphr8g. |
Your Render PR Server URL is https://files-ui-stage-pr-2211.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caven2rru51tqnfphrd0. |
Your Render PR Server URL is https://storage-ui-stage-pr-2211.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caven43ru51tqnfphrug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working correctly, I tried with BlockWallet in Brave and Chrome, as well Metamask in all browsers to make sure that keeps working.
I didn't find any other wallet that I can connect via "Connected" I tried with polkadot{.js} and Phantom in Firefox, but they are not detected by the app
We only support Ethereum based wallets. So pjs and phantom aren't expected to work indeed. |
The hash is something that wallet probably chose to show this way unfortunately, since what we sign is the exact same api token than with |
Thanks for your comment. Since this PR is not related to metamask and has been merged would you mind opening an issue and describe the steps that lead to the issue? |
Sorry. Have deleted my comment. |
closes #2209