Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use personal_sign any connected wallet beside the known ones #2211

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jul 1, 2022

closes #2209

@Tbaut Tbaut requested a review from FSM1 July 1, 2022 12:41
@render
Copy link

render bot commented Jul 1, 2022

@render
Copy link

render bot commented Jul 1, 2022

@render
Copy link

render bot commented Jul 1, 2022

@Tbaut Tbaut marked this pull request as ready for review July 1, 2022 12:42
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working correctly, I tried with BlockWallet in Brave and Chrome, as well Metamask in all browsers to make sure that keeps working.

I didn't find any other wallet that I can connect via "Connected" I tried with polkadot{.js} and Phantom in Firefox, but they are not detected by the app

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jul 4, 2022

We only support Ethereum based wallets. So pjs and phantom aren't expected to work indeed.

@Tbaut Tbaut enabled auto-merge (squash) July 4, 2022 10:02
@FSM1
Copy link
Contributor

FSM1 commented Jul 4, 2022

Seems to be working well here, with the exception of the actual message being signed getting reduced to a hash:
image

Not too sure if there is anything we can really do about that though.

@Tbaut Tbaut merged commit 146d8a8 into dev Jul 4, 2022
@Tbaut Tbaut deleted the tbaut-fix-signing-eth-personal-2209 branch July 4, 2022 10:40
@Tbaut
Copy link
Collaborator Author

Tbaut commented Jul 4, 2022

The hash is something that wallet probably chose to show this way unfortunately, since what we sign is the exact same api token than with eth_sign.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jul 7, 2022

Thanks for your comment. Since this PR is not related to metamask and has been merged would you mind opening an issue and describe the steps that lead to the issue?

@achnir97
Copy link

achnir97 commented Jul 7, 2022

Sorry. Have deleted my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to sign message using EIP1193 Wallet
5 participants