[Storage] Delete file and folder (ipfs and chainsafe types) inside a bucket test #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juans-chainsafe
added
the
Type: Maintenance
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-2233.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbdahand17c7qr6uc73g. |
|
Your Render PR Server URL is https://files-ui-stage-pr-2233.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbdahbvd17c7qr6uc780. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-2233.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbdahd7d17c7qr6uc7pg. |
…lder-storage-test-2227
asnaith
reviewed
Jul 22, 2022
asnaith
reviewed
Jul 22, 2022
asnaith
reviewed
Jul 22, 2022
asnaith
reviewed
Jul 22, 2022
asnaith
reviewed
Jul 22, 2022
asnaith
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
@juans-chainsafe Looks great, thanks for this additional test coverage.
I left a few suggestions for nits but otherwise, this looks good to go 😃
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2227