Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] pin same cid twice test #2234

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2230

We already had the test that check the warning message if we try to pin the same CID, I just completed the flow, adding that cid again, and validate that is present in the table twice

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jul 25, 2022
@juans-chainsafe juans-chainsafe self-assigned this Jul 25, 2022
@juans-chainsafe juans-chainsafe linked an issue Jul 25, 2022 that may be closed by this pull request
@render
Copy link

render bot commented Jul 25, 2022

@render
Copy link

render bot commented Jul 25, 2022

@render
Copy link

render bot commented Jul 25, 2022

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion for readability but looks good :)

@juans-chainsafe juans-chainsafe merged commit b3d6d5b into dev Jul 26, 2022
@juans-chainsafe juans-chainsafe deleted the mnt/pin-the-same-cid-twice-test-2230 branch July 26, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Add pin the same cid twice test
3 participants