Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Input validations pin cid modal test #2235

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2228

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jul 26, 2022
@juans-chainsafe juans-chainsafe self-assigned this Jul 26, 2022
@juans-chainsafe juans-chainsafe linked an issue Jul 26, 2022 that may be closed by this pull request
@render
Copy link

render bot commented Jul 26, 2022

@render
Copy link

render bot commented Jul 26, 2022

@juans-chainsafe juans-chainsafe changed the title Mnt/input validations pin cid modal test 2228 [Storage] Input validations pin cid modal test Jul 26, 2022
@render
Copy link

render bot commented Jul 26, 2022


// ensure can't pin an empty cid
// TODO: uncomment when #2229 issue is fixed
//addCidModal.pinSubmitButton().safeClick()
Copy link
Contributor Author

@juans-chainsafe juans-chainsafe Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this one as well, but because the development is not ready, I leave it commented for now

Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@juans-chainsafe juans-chainsafe merged commit e2e2daf into dev Aug 4, 2022
@juans-chainsafe juans-chainsafe deleted the mnt/input-validations-pin-cid-modal-test-2228 branch August 4, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Add input validations on "Pin a CID" modal test
3 participants