Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add multiple s3 keys test #2247

Merged
merged 12 commits into from
Aug 31, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2242

I will open this PR when #2241 and #2246 are merged

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Aug 17, 2022
@juans-chainsafe juans-chainsafe self-assigned this Aug 17, 2022
@juans-chainsafe juans-chainsafe linked an issue Aug 17, 2022 that may be closed by this pull request
@render
Copy link

render bot commented Aug 17, 2022

@render
Copy link

render bot commented Aug 17, 2022

@render
Copy link

render bot commented Aug 17, 2022

@juans-chainsafe juans-chainsafe changed the title Mnt/can add multiple s3 keys test 2242 [Storage] Add multiple s3 keys test Aug 17, 2022
@juans-chainsafe juans-chainsafe marked this pull request as ready for review August 22, 2022 15:11
@asnaith
Copy link
Member

asnaith commented Aug 22, 2022

Nicely done. Thanks for this @juans-chainsafe, we're in a good spot with Storage after all the recent tests you've added :) 🙏

@juans-chainsafe juans-chainsafe removed their assignment Aug 23, 2022
@juans-chainsafe juans-chainsafe self-assigned this Aug 23, 2022
@juans-chainsafe juans-chainsafe merged commit c91edfd into dev Aug 31, 2022
@juans-chainsafe juans-chainsafe deleted the mnt/can-add-multiple-s3-keys-test-2242 branch August 31, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Can add multiple s3 keys test
5 participants