-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "view folder content from search result" test #2254
Conversation
Your Render PR Server URL is https://storage-ui-stage-pr-2254.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccupmvda499c7rb9ab0g. |
Your Render PR Server URL is https://files-ui-stage-pr-2254.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccupn0ta499c7rb9abe0. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-2254.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccupn2da499c7rb9abvg. |
cy.wait("@refresh") | ||
navigationMenu.homeNavButton().click() | ||
cy.wait("@refresh") | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice reliability improvement 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @juans-chainsafe :)
Test "can view folder content from search result" was failing all the time in the pipeline and sometimes when you test it locally.
I manage to fix it locally adding the refresh for the bucket when you go from bin to home after creating a folder via API (this was implemented in order to be able to see the folder in home).
I also added a validation to be sure that when you perform a search, you are in the correct url