Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "view folder content from search result" test #2254

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

juans-chainsafe
Copy link
Contributor

Test "can view folder content from search result" was failing all the time in the pipeline and sometimes when you test it locally.

I manage to fix it locally adding the refresh for the bucket when you go from bin to home after creating a folder via API (this was implemented in order to be able to see the folder in home).

I also added a validation to be sure that when you perform a search, you are in the correct url

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Oct 5, 2022
@juans-chainsafe juans-chainsafe self-assigned this Oct 5, 2022
@render
Copy link

render bot commented Oct 5, 2022

@render
Copy link

render bot commented Oct 5, 2022

@render
Copy link

render bot commented Oct 5, 2022

@juans-chainsafe juans-chainsafe changed the title add wait refresh after creating the folder + validate url Fix "view folder content from search result" test Oct 5, 2022
cy.wait("@refresh")
navigationMenu.homeNavButton().click()
cy.wait("@refresh")
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reliability improvement 👍

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @juans-chainsafe :)

@juans-chainsafe juans-chainsafe merged commit c60e5f4 into dev Oct 6, 2022
@juans-chainsafe juans-chainsafe deleted the mnt/fix-search-folder-test branch October 6, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants