Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 2023-01-10 #2259

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Release - 2023-01-10 #2259

merged 2 commits into from
Jan 11, 2023

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jan 10, 2023

  • add cloudflare deploy actions

* add cloudflare deploy actions

* revert to node 16 build

* disable source maps

* update deploy scripts

* add staging config

* update stage deployments

* fix verifier name

* set up correct stage ipfs gateway
@render
Copy link

render bot commented Jan 10, 2023

@render
Copy link

render bot commented Jan 10, 2023

Currently translated at 86.3% (355 of 411 strings)

Translation: ChainSafe Files/Chainsafe Files user interface
Translate-URL: https://hosted.weblate.org/projects/chainsafe-files/chainsafe-files-user-interface/de/

Co-authored-by: Ettore Atalan <atalanttore@googlemail.com>
@github-actions github-actions bot temporarily deployed to Production January 10, 2023 15:00 Inactive
@github-actions github-actions bot temporarily deployed to Production January 10, 2023 15:02 Inactive
@render
Copy link

render bot commented Jan 10, 2023

A deploy for your Render PR Server at https://files-ui-prod-pr-2259.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/static/srv-ceunma4gqg41ie21hju0.

@github-actions github-actions bot temporarily deployed to Production January 10, 2023 15:05 Inactive
@github-actions github-actions bot temporarily deployed to Production January 10, 2023 15:07 Inactive
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good !

@asnaith
Copy link
Member

asnaith commented Jan 10, 2023

@FSM1 I think the render bot needs to be replaced with something that posts the Cloudflare links for Files and Storage too?

@FSM1
Copy link
Contributor Author

FSM1 commented Jan 10, 2023

@FSM1 I think the render bot needs to be replaced with something that posts the Cloudflare links for Files and Storage too?

The Render message will not be displayed any more once that is disabled.

The Cloudflare preview URL is already attached to the PR
image

@asnaith
Copy link
Member

asnaith commented Jan 10, 2023

@FSM1 Ah ok, thanks. I didn't realize it was there. That does raise a couple of points:

  • I only see one URL for storage there and none generated Files. Perhaps it's only showing the last deployment?
  • Also perhaps it's worth calling the deployment environment "public staging" or something, rather than "production"?

@FSM1
Copy link
Contributor Author

FSM1 commented Jan 11, 2023

@FSM1 Ah ok, thanks. I didn't realize it was there. That does raise a couple of points:

  • I only see one URL for storage there and none generated Files. Perhaps it's only showing the last deployment?

Yup unfortunately that notification message will only show 1 of the deployments (usually the first one). The actual addresses can be checked by clicking details on the relevant action run, and then inspecting the summary: https://github.com/ChainSafe/ui-monorepo/actions/runs/3884495642

One thing we could try is to add a step to the action yaml file to post a comment on the PR? Improving the messaging around where previews are deployed is definitely not something that should stop the deployment right now though.

  • Also perhaps it's worth calling the deployment environment "public staging" or something, rather than "production"?

Unfortunately Cloudfare does not allow renaming these environments. It regards the deployment's main branch as the production branch, and all others as preview branches.

@FSM1 FSM1 enabled auto-merge (squash) January 11, 2023 12:05
@asnaith
Copy link
Member

asnaith commented Jan 11, 2023

Yup unfortunately that notification message will only show 1 of the deployments (usually the first one). The actual addresses can be checked by clicking details on the relevant action run, and then inspecting the summary: https://github.com/ChainSafe/ui-monorepo/actions/runs/3884495642

@FSM1 Ah ok as long as we can get there, all good. cc @juans-chainsafe

One thing we could try is to add a step to the action yaml file to post a comment on the PR? Improving the messaging around where previews are deployed is definitely not something that should stop the deployment right now though.

For sure, just wanted to mention this at the point of the change 👍

Unfortunately Cloudfare does not allow renaming these environments. It regards the deployment's main branch as the production branch, and all others as preview branches.

Oh that's too bad, ok. It could confuse new people so will try and remember this.

@FSM1 FSM1 merged commit ddd45bd into prod Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants