-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - 2023-01-10 #2259
Release - 2023-01-10 #2259
Conversation
FSM1
commented
Jan 10, 2023
•
edited
Loading
edited
- add cloudflare deploy actions
* add cloudflare deploy actions * revert to node 16 build * disable source maps * update deploy scripts * add staging config * update stage deployments * fix verifier name * set up correct stage ipfs gateway
Your Render PR Server URL is https://files-ui-prod-pr-2259.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ceunma4gqg41ie21hju0. |
Your Render PR Server URL is https://storage-ui-prod-pr-2259.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ceunmbcgqg41ie21hkhg. |
Currently translated at 86.3% (355 of 411 strings) Translation: ChainSafe Files/Chainsafe Files user interface Translate-URL: https://hosted.weblate.org/projects/chainsafe-files/chainsafe-files-user-interface/de/ Co-authored-by: Ettore Atalan <atalanttore@googlemail.com>
A deploy for your Render PR Server at https://files-ui-prod-pr-2259.onrender.com just failed. View details on your dashboard at https://dashboard.render.com/static/srv-ceunma4gqg41ie21hju0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good !
@FSM1 I think the render bot needs to be replaced with something that posts the Cloudflare links for Files and Storage too? |
The Render message will not be displayed any more once that is disabled. |
@FSM1 Ah ok, thanks. I didn't realize it was there. That does raise a couple of points:
|
Yup unfortunately that notification message will only show 1 of the deployments (usually the first one). The actual addresses can be checked by clicking One thing we could try is to add a step to the action yaml file to post a comment on the PR? Improving the messaging around where previews are deployed is definitely not something that should stop the deployment right now though.
Unfortunately Cloudfare does not allow renaming these environments. It regards the deployment's main branch as the production branch, and all others as preview branches. |
@FSM1 Ah ok as long as we can get there, all good. cc @juans-chainsafe
For sure, just wanted to mention this at the point of the change 👍
Oh that's too bad, ok. It could confuse new people so will try and remember this. |