-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forgetting browser warning #928
Conversation
Your Render PR Server URL is https://chainsafex-dev-pr-928.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1rhvjbs1gh4cd7amfc0. |
Your Render PR Server URL is https://files-ui-dev-pr-928.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1rhvjrs1gh4cd7amfhg. |
Your Render PR Server URL is https://files-landing-dev-pr-928.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1rhvkbs1gh4cd7amg50. |
packages/files-ui/src/Components/Modules/Settings/SavedBrowsers/BrowserPanel.tsx
Outdated
Show resolved
Hide resolved
Code works great. I think the text update in the browser panel should be included in this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggestions for naming and code removing the text above the delete button.
Also more importantly:
The modal doesn't close upon deleting a browser. You need to set back the flag to false in onDeleteShare
.
packages/files-ui/src/Components/Modules/Settings/SavedBrowsers/BrowserPanel.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SavedBrowsers/BrowserPanel.tsx
Outdated
Show resolved
Hide resolved
…s/BrowserPanel.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@tanmoyAtb did you forget to push maybe :) ? |
all updated now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, just a little comment, but looks great otherwise.
packages/files-ui/src/Components/Modules/Settings/SavedBrowsers/BrowserPanel.tsx
Show resolved
Hide resolved
…s/BrowserPanel.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good 💯
closes #904
We might want to remove the text above
forget the browser
button in expansion panel since we already have the warning.