Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Countly to the latest version and supressing bunch of the warnings coming from it. #1251

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Updating Countly to the latest version and supressing bunch of the warnings coming from it. #1251

wants to merge 7 commits into from

Conversation

kantagara
Copy link
Contributor

This should close #1237 #1221

@kantagara
Upgraded Countly to the latest SDK
e9eee79 
* Cleaned up SDK (i.e. added bunch of pragma disables) so that there are no warnings.
@kantagara kantagara changed the base branch from main to dev December 4, 2024 07:33
@kantagara kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks documented Apply on Pull Request after documentation to allow merge labels Dec 4, 2024
@kantagara kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Dec 4, 2024
@kantagara kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Dec 4, 2024
juans-chainsafe
juans-chainsafe requested changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New events are displayed if you are trying in WebGL, but no 1 single event is displayed when I try from the editor.

Also, new user profiles are not displayed/created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juans-chainsafe juans-chainsafe juans-chainsafe requested changes

@creeppak creeppak creeppak approved these changes

@sneakzttv sneakzttv sneakzttv approved these changes

@rob1997 rob1997 rob1997 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@kantagara kantagara

Labels
documented Apply on Pull Request after documentation to allow merge ready-to-merge Ready to Merge PR - this'll trigger required checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Countly not logging any events or user profiles
5 participants
@kantagara @rob1997 @sneakzttv @creeppak @juans-chainsafe