-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LlamaIndex instrumentation #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desaxce
commented
Sep 26, 2024
@@ -0,0 +1,166 @@ | |||
from typing_extensions import TypedDict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untouched, just moved.
desaxce
commented
Sep 27, 2024
desaxce
commented
Sep 28, 2024
|
||
def instrument_llamaindex(client: "LiteralClient"): | ||
global is_llamaindex_instrumented | ||
if is_llamaindex_instrumented: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple instrumentations of llamaindex lead to steps with cycles.
willydouhard
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
llm.chat
andllm.stream_chat
,llm.predict
,llm.predict_and_call
,OpenAIAgent.chat
andFunctionCallingAgent.chat
.To test:
Generation
llm.chat
llm.stream_chat
llm.predict
For the specific case of
llm.predict_and_call
, LlamaIndex does not fire an event for the tool calls that take place. Hence:llm.predict_and_call
in a step or a thread (so that the tool steps have a parent, they cannot be standalone)llm.predict_and_call
simply shows aGeneration
logTicket for LlamaIndex to add
ToolCallStartEvent
andToolCallEndEvent
: run-llama/llama_index#16231agent.chat
shows:Again, tool calls don't show. However, in the specific case of agents, LlamaIndex fires a
AgentToolCallEvent
prior to calling the tool. It's not enough to create a full tool step, and I decided it was best to let users decorate their own FunctionTool if they needed logs at that level.There is an option to refactor the span handler logic to catch the FunctionTool spans that are fired. There are a couple issues related to duplicate firing (nested) and a small revamp of the logic to allow the span handler to open/end steps.