Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update prompt version definition #136

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

clementsirieix
Copy link
Contributor

@clementsirieix clementsirieix commented Oct 25, 2024

Changes

  • Add new fields to the definition

How to test?

  • Import a prompt, notice that you receive the new fields

@clementsirieix clementsirieix added the enhancement New feature or request label Oct 25, 2024
@clementsirieix clementsirieix self-assigned this Oct 25, 2024
@@ -176,6 +176,7 @@ async def test_step(self, client: LiteralClient, async_client: AsyncLiteralClien
await async_client.flush()
is_deleted = await async_client.api.delete_step(id=step.id)
assert is_deleted is True, "Step should be deleted"
time.sleep(1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix flakky test

Copy link
Contributor

@desaxce desaxce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clementsirieix clementsirieix merged commit 7c661a2 into main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants