feat: create_score add warn when passing genration_id #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Matthieu-OD
commented
Oct 28, 2024
Matthieu-OD
commented
desaxce
suggested changes
Oct 28, 2024
There was a problem hiding this comment.
@Matthieu-OD I have an error when creating a score with generation_id:
Side note: all our Python APIs have async counterparts, we unfortunately have to update both definitions every time.
the error comes from the fact that you dont pass a step id or other type of argument thx missed the async version of the function |
Matthieu-OD
deleted the
matt/eng-1877-create_score-has-step_id-and-generation_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.