Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1158] Default participant identifier to None and select 'id' as dict #59

Merged

Conversation

desaxce
Copy link
Contributor

@desaxce desaxce commented Apr 18, 2024

This pull request allows users to change the participant ID in a thread.

First issue came up with with client.thread() as thread and trying to change thread.participant_id because the upsert was looking at the wrong field.

Second issue comes from the to_dict method which attempts to read self.participant_identifier, that's why we need to initialize it to None.

  • Add test

This change is Reviewable

Copy link

linear bot commented Apr 18, 2024

ENG-1158 Cookbook example: Evaluate conversation

Add cookbook on how to evaluate a discussion. Rating a conversation.

Goal: from the beginning, conv is well supported

Example cookbook: customer satisfaction evaluation

@desaxce desaxce requested a review from willydouhard April 18, 2024 14:43
Copy link
Contributor

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @desaxce)

Copy link
Contributor

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @desaxce)

@willydouhard willydouhard merged commit 1a18e80 into main Apr 23, 2024
3 checks passed
@willydouhard willydouhard deleted the hugues/eng-1158-cookbook-example-evaluate-conversation branch April 23, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants