-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-1158] Default participant identifier to None and select 'id' as dict #59
[ENG-1158] Default participant identifier to None and select 'id' as dict #59
Conversation
ENG-1158 Cookbook example: Evaluate conversation
Add cookbook on how to evaluate a discussion. Rating a conversation. Goal: from the beginning, conv is well supported Example cookbook: customer satisfaction evaluation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @desaxce)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @desaxce)
This pull request allows users to change the participant ID in a thread.
First issue came up with
with client.thread() as thread
and trying to changethread.participant_id
because theupsert
was looking at the wrong field.Second issue comes from the
to_dict
method which attempts to readself.participant_identifier
, that's why we need to initialize it toNone
.This change is