-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for tags with OpenAI Instrumentation #63
Conversation
ENG-1145 OpenAI Instrumentation with metadata and tags
This is important for ppl only using the instrumentation. How do they pass in the user, metadata or tags? DoD:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Granipouss)
literalai/instrumentation/openai.py
line 192 at r1 (raw file):
step.input = {"content": generation.prompt} step.tags = kwargs.get("literal_tags", [])
I think the tags should go the generation and not the step
literalai/instrumentation/openai.py
line 218 at r1 (raw file):
step.input = {"content": generation.prompt} step.tags = kwargs.get("literal_tags", [])
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Granipouss)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Granipouss)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @willydouhard)
literalai/instrumentation/openai.py
line 218 at r1 (raw file):
Previously, willydouhard (Willy Douhard) wrote…
same here
Done.
https://linear.app/chainlit/issue/ENG-1145/openai-instrumentation-with-metadata-and-tags
In the wrapper we have to remove extra arguments because OpenAI throws if we don't.
Documentation incoming...
This change is