-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix open debug playground #93
Conversation
ENG-1698 fix langchain callback when linking prompt
=> FIX
|
You should run the precommit locally to make sure the formatting/type checking is passing @constantinidan |
I'd introduced a bug in #86. So I added:
@willydouhard Did we use to have a Langchain example where we have a JSON-formatted variable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny comment
examples/langchain_variable.py
Outdated
) | ||
messages = prompt.to_langchain_chat_prompt_template() | ||
|
||
inp = messages.format_messages( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is an example, can you plz change to a more explicit variable name ?
https://linear.app/literalai/issue/ENG-1698/fix-langchain-callback-when-linking-prompt