Bugfix/keystone become #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure regex capture group includes line beginning or ending to handle different python interpereters This is called out in https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#selecting-values-from-arrays-or-hashtables
diurnalist
approved these changes
Sep 15, 2021
diurnalist
pushed a commit
that referenced
this pull request
Oct 28, 2021
* ensure certificate can be created * refactor mapping to be more readable, fix regex ensure regex capture group includes line beginning or ending to handle different python interpereters This is called out in https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#selecting-values-from-arrays-or-hashtables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 1 is trivial, ensuring become: true is set so metadata files can be created
fix 2 is tricky: when creating a capture group to get the entire string, it is important to specify the line start and end. Specifically, use
^(.*)$not(.*)If this is not done, the capture group may return an empty string as an extra result, depending on platform and python version.
This is documented at https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#searching-strings-with-regular-expressions
Finally, I would recommend formatting chains of map, select, list, onto multiple lines as shown for readability, and ease of diffing.