-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voting threshold #152
Voting threshold #152
Conversation
I'd maybe do it off a percentage of active participants. Would prevent any deadlocks from occurring |
@rudehn I'm all for it. Any ideas how to retrieve that? |
With #140 we could check against the number of people who have X or more points. |
Oh shit I voted against that 😆 |
@ECrownofFire sure that's one solution. It would definitely pick up on anybody who has voted for PRs. In the long run even that could get stale if somebody hasn't voted in a long time. Maybe storing some kind of "last active" per user could be useful |
@rudehn I was planning to suggest using a certain amount of point decay over time (for each PR) to avoid that. |
Sounds good! |
I would just like to point out this PR would not pass if this was currently implemented. Perhaps the threshold should be adjusted more? |
Good point, yeah I think so. Although I'm leaning towards a conservative threshold, of course that conflicts with creating chaos. Hmmm... Maybe 0.5% (=7 votes difference atm) is better? |
As already mentioned, time decay is a better solution. |
🙆♀️ PR passed with a vote of 18 for and 2 against, with a weighted total of 16.0 and a threshold of 1.0. See merge-commit efb724b for more details. |
There should be a voting threshold (it's actually a threshold on the votes difference).
Set to 1% of repo followers (currently, that means the difference between 👍 and 👎 should be at least 12).
Prevents things like #138 and #48.
Maybe we can change this later to use a percentage of active contributors instead of (possibly passive) stargazers? Not sure how to calculate that atm though.