Use HTTPS and SRI integrity in all scripts and styles in website #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced protocol relative URLs to HTTPS URLs, following the current best practices: https://jeremywagner.me/blog/stop-using-the-protocol-relative-url Also added SRI integrity attribute to the jQuery script.
pchauncey
approved these changes
May 24, 2017
xyproto
approved these changes
May 24, 2017
|
🙅 This PR did not meet the required vote threshold and will not be merged. Closing. Open a new PR to restart voting. |
|
Try this again with #153 accepted |
|
@rudehn Not needed as someone already did almost the same changes, except that integrity attribute was removed from all scripts and styles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces protocol relative URLs to HTTPS URLs, following the current best practices:
https://jeremywagner.me/blog/stop-using-the-protocol-relative-url
It also adds the SRI integrity attribute to the jQuery script, which was missing.