Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: skip newline after automatically inserted newlines #33

Open
wants to merge 1 commit into
base: hacketyhack
Choose a base branch
from
Open

bugfix: skip newline after automatically inserted newlines #33

wants to merge 1 commit into from

Conversation

sknebel
Copy link
Member

@sknebel sknebel commented Jan 4, 2020

No description provided.

@cyroxx
Copy link
Member

cyroxx commented Jan 4, 2020

Using this ascii_art.txt and an ERIKA_MAX_LINE_LENGTH=65, I still get empty lines on the physical device.

@ArchibaldBienetre
Copy link

@cyroxx @sknebel isn't hacketyhack merged already?

Can we close this PR then? :)

@ArchibaldBienetre
Copy link

ArchibaldBienetre commented Jan 22, 2020 •
edited
Loading

Maybe erika.util.remove_trailing_newlines is an option.

@sirexeclp
Copy link

maybe this can be used https://docs.python.org/3.1/library/textwrap.html

@sirexeclp sirexeclp force-pushed the hacketyhack-bugfix branch 2 times, most recently from 143e1a2 to 74586b5 Compare January 24, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sknebel @cyroxx @ArchibaldBienetre @sirexeclp