Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setDirectory function #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add setDirectory function #4

wants to merge 1 commit into from

Conversation

dj1vs
Copy link

@dj1vs dj1vs commented Feb 10, 2024

setDirectory function opens terminal in a specified folder (just a cd command)

@ChargeIn
Copy link
Owner

Hey, thanks for the pull request, its good idea.

Since there is currently terminal does not have a setStartDirectory function most people will probably use this command to change the default directory the terminal is started in. This is a bit problematic, since the terminal takes some time to start and causes the command to generate duplicate entries on start up.

Screenshot from 2024-02-11 21-34-35

Furthermore we cannot simply call commands like "clear" afterwards since some terminals provide start up information.

So we would need to solve this first.

Also please move the function below the signal function e.g. the updateTerminal function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants