Clean up project structure and bump version to 2.0 #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-s-ubi
force-pushed
the
clean_up_project_structure
branch
from
d69e963 to
436f404
Compare
This was referenced Dec 6, 2025
Closed
Also clean up dependencies and make them consistent, and unify spacing across pom.xml files.
robert-s-ubi
force-pushed
the
clean_up_project_structure
branch
from
436f404 to
2711952
Compare
jmluy
reviewed
Dec 11, 2025
Contributor
jmluy
left a comment
jmluy
left a comment
There was a problem hiding this comment.
Minor comment/question but otherwise LGTM
| <version>0.0.1-SNAPSHOT</version> | ||
| <name>json-server-implementation </name> | ||
| <description>Example Spring Application of a json server </description> | ||
| <artifactId>ocpp16-json-server-example</artifactId> |
Contributor
There was a problem hiding this comment.
Not a bug but do you want to rename the directory for the server example to match the client?
Contributor
Author
There was a problem hiding this comment.
Not really. I renamed the OCPP-J directory, because it was sticking out like a sore thumb, but otherwise left existing directory names untouched.
The inconsistencies in the directory names here are minor, so I think renaming them is not worth the possible confusion.
Contributor
There was a problem hiding this comment.
Ok, it's just a minor inconsistency.
jmluy
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the project structure, separating OCPP 1.6J and OCPP 1.6S support.
Rename the artifacts to more descriptive names.
Unify names and descriptions across all gradle and maven build files.
Update README.md with a description of the new project structure.
Bump the library version to 2.0 and the artifacts versions to 2.0.0.