Skip to content

Commit

Permalink
recent project: Fix highlighting for matches in SSH projs (zed-indust…
Browse files Browse the repository at this point in the history
…ries#18332)

Release Notes:

- N/A

Co-authored-by: Bennet <bennet@zed.dev>
  • Loading branch information
mrnugget and bennetbo authored Sep 25, 2024
1 parent 300bf87 commit 4e2ae06
Showing 1 changed file with 7 additions and 19 deletions.
26 changes: 7 additions & 19 deletions crates/recent_projects/src/recent_projects.rs
Original file line number Diff line number Diff line change
Expand Up @@ -259,23 +259,12 @@ impl PickerDelegate for RecentProjectsDelegate {
dev_server_project.paths.join("")
)
}
SerializedWorkspaceLocation::Ssh(ssh_project) => {
format!(
"{}{}{}{}",
ssh_project.host,
ssh_project
.port
.as_ref()
.map(|port| port.to_string())
.unwrap_or_default(),
ssh_project.paths.join(","),
ssh_project
.user
.as_ref()
.map(|user| user.to_string())
.unwrap_or_default()
)
}
SerializedWorkspaceLocation::Ssh(ssh_project) => ssh_project
.ssh_urls()
.iter()
.map(|path| path.to_string_lossy().to_string())
.collect::<Vec<_>>()
.join(""),
};

StringMatchCandidate::new(id, combined_string)
Expand Down Expand Up @@ -458,6 +447,7 @@ impl PickerDelegate for RecentProjectsDelegate {
.order()
.iter()
.filter_map(|i| paths.paths().get(*i).cloned())
.map(|path| path.compact())
.collect(),
),
SerializedWorkspaceLocation::Ssh(ssh_project) => Arc::new(ssh_project.ssh_urls()),
Expand All @@ -473,7 +463,6 @@ impl PickerDelegate for RecentProjectsDelegate {
let (match_labels, paths): (Vec<_>, Vec<_>) = paths
.iter()
.map(|path| {
let path = path.compact();
let highlighted_text =
highlights_for_path(path.as_ref(), &hit.positions, path_start_offset);

Expand Down Expand Up @@ -704,7 +693,6 @@ fn highlights_for_path(
},
)
}

impl RecentProjectsDelegate {
fn delete_recent_project(&self, ix: usize, cx: &mut ViewContext<Picker<Self>>) {
if let Some(selected_match) = self.matches.get(ix) {
Expand Down

0 comments on commit 4e2ae06

Please sign in to comment.