Abstract class for pool datums and order datums

[bhatt-deep]

@theeldermillenial I have implemented the initial abstract classes and extended them in the Sundae DEX. Could you please take a quick look to confirm that this is the correct approach before I proceed further?

[theeldermillenial]

Hey @bhatt-deep!

This looks mostly good. However, there are two things to modify:

1. you will need to remove the dataclass decorator from OrderDatum
2. you will need to change the OrderDatum(PlutusData) to OrderDatum(PlutusData, ABC), using from abc import ABC

Python has various issues with dataclass inheritance, one of which being dataclass attributes with default arguments. Basically, you can't really set default arguments on parent dataclasses because things go haywire. There is an option in Python 3.10 to assist with this, but that would mean that we only support Python 3.10+
https://stackoverflow.com/questions/69711886/python-dataclasses-inheritance-and-default-values

My recommendation is to make the parent class not a dataclass.

For the second part, I forget if this is still the case, but the abstractmethod used to not be enforced unless it was a method on an ABC class. You'll have to double check, but I'm pretty sure this is still the case.

[bhatt-deep]

Hey @theeldermillenial , Thank you for the feedback! I've made the necessary changes and extended the implementation across the remaining DEXs.