Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async operations + updated frameworks #158

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

adimosh
Copy link
Contributor

@adimosh adimosh commented Jul 11, 2022

  • Updated the target frameworks to the officially-supported Microsoft versions
  • Added asynchronous methods, and unit tests for those asynchronous methods

Please note that this PR has not been previewed by the project contributors, and has not obtained their approval beforehand. Please feel free to let me know if it went in a direction that you don't want to go in.

src/UTF-unknown.csproj Outdated Show resolved Hide resolved
@adimosh
Copy link
Contributor Author

adimosh commented Jul 11, 2022

This should fix #23 and #135 at the same time.

@304NotModified
Copy link
Member

Thanks, will also review this week :)

@304NotModified
Copy link
Member

Sorry the review delay. Will try this weekend

@304NotModified 304NotModified self-assigned this Jul 20, 2022
@304NotModified
Copy link
Member

Im doubting about the support of the platforms, see #145 (comment)

Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added some notes.

src/CharsetDetector.cs Outdated Show resolved Hide resolved
src/CharsetDetector.cs Outdated Show resolved Hide resolved
tests/CharsetDetectorTest.cs Show resolved Hide resolved
@304NotModified 304NotModified removed their assignment Jul 26, 2022
@adimosh adimosh requested a review from 304NotModified August 3, 2022 06:30
@304NotModified
Copy link
Member

Will try to review this soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants