Resolve todo fix cp949 to ks_c_5601-1987 #86
Conversation
|
@HelloWorld017, hello! I decided to get around this way, so that it was more general. |
src/DetectionDetail.cs
Outdated
| /// A dictionary for replace unsupported codepage name in .NET to the nearly identical version. | ||
| /// </summary> | ||
| /// <remarks>ReadOnlyDictionary start support with .NET Framework 4.5</remarks> | ||
| private readonly Dictionary<string, string> _fixedToSupportCodepageName = |
There was a problem hiding this comment.
Maybe a dictionary is a bit unneeded. What about a if in the method above?
There was a problem hiding this comment.
I would also like to add
Not supported iso-2022-ch? Maybe fix to x-cp50227?
from #78
It can also be expanded in the future.
There was a problem hiding this comment.
It's OK if we add those then.
PS I would remove the ReadOnlyDictionary comment. It's a private.
There was a problem hiding this comment.
Ow One other thing , this dictionary could be static? As there is no need to recalculate the values multiple times.
There was a problem hiding this comment.
Yes, I didn’t think about it.
|
cool! nice improvement! Thanks again :) |
Resolve part #78