Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix todo: ISO-2022-CN is x-cp50227 in .NET #97

Merged
merged 6 commits into from
Nov 16, 2019
Merged

Fix todo: ISO-2022-CN is x-cp50227 in .NET #97

merged 6 commits into from
Nov 16, 2019

Conversation

rstm-sf
Copy link
Collaborator

@rstm-sf rstm-sf commented Nov 15, 2019

Resolve task #78

Not supported iso-2022-ch? Maybe fix to x-cp50227?

Sorry, but I could not find an example.

@rstm-sf rstm-sf changed the title Fix todo: ISO-2022-CN is x-cp50227 in .NET WIP: Fix todo: ISO-2022-CN is x-cp50227 in .NET Nov 15, 2019
@rstm-sf
Copy link
Collaborator Author

rstm-sf commented Nov 15, 2019

I'm confused, I’ll fix it now

@rstm-sf rstm-sf changed the title WIP: Fix todo: ISO-2022-CN is x-cp50227 in .NET Fix todo: ISO-2022-CN is x-cp50227 in .NET Nov 15, 2019
@304NotModified 304NotModified self-assigned this Nov 16, 2019
@304NotModified
Copy link
Member

so 50229 is unsupported but also iso-2022-ch? But x-cp50227 is supported?

@304NotModified 304NotModified added this to the 2.3 milestone Nov 16, 2019
@rstm-sf
Copy link
Collaborator Author

rstm-sf commented Nov 16, 2019

Yes, I somehow wrote with a double meaning.

If you go to get the encoding by identifier 50229, then you will get an exception in .NET Framework:

System.NotSupportedException : The ISO-2022-CN Encoding (Code page 50229) is not supported.

It is possible that it was or was supposed to be ISO-2022-CN-EXT encoding.

x-cp50227 has the identifier 50227 and is ISO-2022-CN encoding according to the doc/win32.

P.S. Now I need to make 2 edits

@rstm-sf
Copy link
Collaborator Author

rstm-sf commented Nov 16, 2019

P.S. Now I need to make 2 edits

Done

@304NotModified 304NotModified merged commit 9f6a0d6 into CharsetDetector:master Nov 16, 2019
@304NotModified
Copy link
Member

Thanks!

@rstm-sf rstm-sf mentioned this pull request Dec 7, 2019
@rstm-sf rstm-sf deleted the bugfix/todo_iso-2022-ch_is_equal_x-cp50227 branch January 12, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants