Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Fix bubble overlap selection 👾 #1049

Closed
wants to merge 2 commits into from
Closed

- Fix bubble overlap selection 👾 #1049

wants to merge 2 commits into from

Conversation

chuynadamas
Copy link
Contributor

@danielgindi
Copy link
Collaborator

Man you're breaking everything here, an not even doing so in a clean manner.

If the highlight is not working for you - then your dataset is not correct.
You may have an unordered dataset, where in Charts all datasets should be ordered.

We may change that requirement in the future, but currently that helps avoiding calculating and rendering values which are out of viewport.

@chuynadamas
Copy link
Contributor Author

Sorry for the dirty way - I just wanted to show that the problem was that Charts only works with ordered data sets, I didn't notice about this constraint.

Thanks in advance.

@danielgindi
Copy link
Collaborator

It's really ok! Thanks for your efforts!

@chuynadamas chuynadamas deleted the selection_BubbleOverlap branch May 26, 2016 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuynadamas @danielgindi