Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center align multiple lines of no data text #2026

Closed
wants to merge 1 commit into from

Conversation

edwardmarks
Copy link

I believe this is the expected behavior of no data text.

The current behavior, if you write multiple lines (i.e. chartView.noDataText = "No Data Yet\n(check back in a bit)" is for them to left-align to each other. Given that a single line is centered within the chart, the expected behavior is that multiple lines would be centered within the chart.

@jjatie
Copy link
Collaborator

jjatie commented Jan 18, 2018

@liuxuan30 can you please verify if this is desired?
@edwardmarks Can you please pull master.

@jjatie jjatie added this to the 3.1 milestone Jan 23, 2018
@jjatie jjatie self-assigned this Jan 23, 2018
@jjatie
Copy link
Collaborator

jjatie commented Jan 26, 2018

@liuxuan30 This seems like something we want, what do you think? I'll make a new PR for 3.1 if we do.

@jjatie
Copy link
Collaborator

jjatie commented Jan 27, 2018

#3199 provides custom alignment

@jjatie jjatie closed this Jan 27, 2018
@jjatie jjatie removed this from the 3.1 milestone Jan 27, 2018
@ChartsOrg ChartsOrg locked as resolved and limited conversation to collaborators Jan 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants