Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Simple Bar Chart Demo, switch use of x and y values #2365

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

franqueli
Copy link
Contributor

The demo broke in the following commit fbba515
The x and y values were switched.

@liuxuan30
Copy link
Member

Thanks! I saw bar chart behaves weird, and just came across this PR!

@liuxuan30 liuxuan30 merged commit aca0491 into ChartsOrg:master Apr 19, 2017
Neral pushed a commit to Neral/Charts that referenced this pull request Apr 24, 2017
…l/update_upstream

* commit '04c5820a6cca34b98cb48b8baab1dd44f44e857d': (61 commits)
  add switch for clearing `lastHighlighted` in clear() (ChartsOrg#2355)
  update schemes, move script to file like ChartsRealm
  use name instead of uuid, add run script for copying missing framework for ChartsTests
  1. use xcode 8.3 image 2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI
  Fix Simple Bar Chart Demo, switch use of x and y values (ChartsOrg#2365)
  Converted swift 3.0 DBL_MIN leftover
  Removed leftover script from the combined Realm era
  Removed leftover scheme
  v3.0.2
  Removed unrequited script
  gitignore updates
  Added @discardableResult to silence warnings when it’s safe to ignore result
  Moved Realm stuff to https://github.com/danielgindi/ChartsRealm
  Remove line width minimum constraint
  Updated build-dependencies.sh
  loosen realm version requirement
  fix Xcode 8.3 compiler warnings
  fix ChartsOrg#2222 move default backgroundColor to initialize() as initWithCoder also needs it
  Updated to use Realm version 2.4.3
  Consider _yAxis.isDrawLimitLinesBehindDataEnabled for radar chart
  ...

# Conflicts:
#	Source/ChartsRealm/Data/RealmBarDataSet.swift
Neral pushed a commit to Neral/Charts that referenced this pull request Apr 24, 2017
…l/update_upstream

* commit '04c5820a6cca34b98cb48b8baab1dd44f44e857d': (61 commits)
  add switch for clearing `lastHighlighted` in clear() (ChartsOrg#2355)
  update schemes, move script to file like ChartsRealm
  use name instead of uuid, add run script for copying missing framework for ChartsTests
  1. use xcode 8.3 image 2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI
  Fix Simple Bar Chart Demo, switch use of x and y values (ChartsOrg#2365)
  Converted swift 3.0 DBL_MIN leftover
  Removed leftover script from the combined Realm era
  Removed leftover scheme
  v3.0.2
  Removed unrequited script
  gitignore updates
  Added @discardableResult to silence warnings when it’s safe to ignore result
  Moved Realm stuff to https://github.com/danielgindi/ChartsRealm
  Remove line width minimum constraint
  Updated build-dependencies.sh
  loosen realm version requirement
  fix Xcode 8.3 compiler warnings
  fix ChartsOrg#2222 move default backgroundColor to initialize() as initWithCoder also needs it
  Updated to use Realm version 2.4.3
  Consider _yAxis.isDrawLimitLinesBehindDataEnabled for radar chart
  ...

# Conflicts:
#	Source/ChartsRealm/Data/RealmBarDataSet.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants