Minor changes to improve clarity and reduce amount of code #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2017 10:51
Making use of `defer` where appropriate (e.g. `CGContext().saveGState()` / `CGContext().restoreGState()`) Using replaced `if` where really meaning `guard`, and `if case` with `switch` where appropriate. Much less nesting as a result. Making use of `Swift.min` and `Swift.max` Changed some `Double` to `CGFloat` where it makes sense to. This also reduces typecasting. Refined `for` loops, in some cases replacing them with `map`, `filter`, and/or `reduce`
|
There appears to be an inconsistent compiler bug preventing this from building. I am investigating further this week. |
|
Thanks for the improvements but I think we should wait until after swift 4 support is merged to do this. |
Merged
|
Tests are passing fine for me locally, any thoughts on why they're failing in Travis CI? |
|
I'm going to take a more structured approach to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making use of
deferwhere appropriate (e.g.CGContext().saveGState()/CGContext().restoreGState())Using replaced
ifwhere really meaningguard, andif casewithswitchwhere appropriate. Much less nesting as a result.Making use of
Swift.minandSwift.maxChanged some
DoubletoCGFloatwhere it makes sense to. This also reduces typecasting.Refined
forloops, in some cases replacing them withmap,filter, and/orreduce