Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BarChartRenderer Logic cleanup #3008

Merged
merged 10 commits into from
Jan 6, 2018
Merged

BarChartRenderer Logic cleanup #3008

merged 10 commits into from
Jan 6, 2018

Commits on Nov 14, 2017

  1. Logic cleanup 

    Mostly using guard where appropriate
Few very minor performance improvements
    @jjatie
    jjatie committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    42109d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. Made use of == where appropriate to simplify logic

    @jjatie
    jjatie committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    b1b8e64 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into bar-chart-rendere… 

    …r-cleanup
    @jjatie
    jjatie committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    f4df33b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2017

  1. Returned fatalError message

    @jjatie
    jjatie committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    41b3961 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into bar-chart-rendere… 

    …r-cleanup
    @jjatie
    jjatie committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    a195e06 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2017

  1. Replaced Buffer class 

    with simple typealias. There was only one instance where reference semantics might have be helpful, but was easily reimplemented with value semantics.
    @jjatie
    jjatie committed Nov 25, 2017
    Configuration menu
    Copy the full SHA
    7395ee5 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2017

  1. Merge branch 'master' into bar-chart-renderer-cleanup

    @jjatie
    jjatie authored Nov 29, 2017
    Configuration menu
    Copy the full SHA
    056ec6f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Merge remote-tracking branch 'upstream/master' into bar-chart-rendere… 

    …r-cleanup
    @jjatie
    jjatie committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    f4782ce View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2018

  1. Merge remote-tracking branch 'upstream/4.0.0' into bar-chart-renderer… 

    …-cleanup
    @jjatie
    jjatie committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    08eb8ba View commit details
    Browse the repository at this point in the history

  2. Pulled latest 4.0.0

    @jjatie
    jjatie committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    c59b73b View commit details
    Browse the repository at this point in the history