Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating 4.0.0 with latest changes in master #3130

Merged
merged 31 commits into from
Dec 24, 2017
Merged

Updating 4.0.0 with latest changes in master #3130

merged 31 commits into from
Dec 24, 2017

Commits on Nov 2, 2017

  1. Configuration menu
    Copy the full SHA
    37c8a77 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2017

  1. Configuration menu
    Copy the full SHA
    69d12af View commit details
    Browse the repository at this point in the history
  2. Resubmit of #2730

    jjatie committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    d1b4fcf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. Configuration menu
    Copy the full SHA
    cd0b984 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d864fb5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48386a3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    40bb001 View commit details
    Browse the repository at this point in the history
  5. Fixes for PR

    jjatie committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    9ea3c20 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2017

  1. Removed @objc from internal properties

    Since the framework is entirely Swift, internal properties do not need to be marked as @objc
    jjatie committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    6869d85 View commit details
    Browse the repository at this point in the history
  2. Removed isKind(of:)

    in favour of the Swift `is`
    jjatie committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    c7a1c04 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2017

  1. Animator non nil (#2981)

    * `Animator` is now non-optional in `Renderer` types
    
    * Fixed merge with master
    jjatie authored and liuxuan30 committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    122013e View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. View port handler nonnil (#2980)

    * `ViewPortHandler` is now non-optional in all, if not most cases
    
    * Removed unnecessary `init()`s from `ViewPortHandler` and related
    
    * `Renderer` now has a constant `ViewPortHandler`
    
    * Pulled latest master
    
    * Fixes for PR review
    
    Removed extraneous comment
    Removed extra whitespace
    
    * Removed extra new lines
    jjatie authored and liuxuan30 committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    fb02977 View commit details
    Browse the repository at this point in the history
  2. ChartRenderer's must be initialized with a chart (#2982)

    * `ViewPortHandler` is now non-optional in all, if not most cases
    
    * Removed unnecessary `init()`s from `ViewPortHandler` and related
    
    * `Renderer` now has a constant `ViewPortHandler`
    
    * `ChartRenderer`'s must be initialized with a chart
    
    * CombinedChartRenderer gets the same treatment
    
    * Pulled latest master
    
    * Pulled latest master
    
    * Removed unnecessary comment
    
    * Removed unnecessary whitespace
    jjatie authored and liuxuan30 committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    0f74a25 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2017

  1. Merge pull request #3044 from jjatie/iskind-of

    Removed `isKind(of:)`
    liuxuan30 authored Dec 5, 2017
    Configuration menu
    Copy the full SHA
    19da2c0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3038 from jjatie/internal-drop-objc

    Removed @objc from internal properties
    liuxuan30 authored Dec 5, 2017
    Configuration menu
    Copy the full SHA
    b87d04e View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2949 from maciejtrybilo/master

    Fix turning off drag in X and Y axes separately.
    liuxuan30 authored Dec 5, 2017
    Configuration menu
    Copy the full SHA
    60829b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. fileprivate -> private (#3042)

    almsot all cases of fileprivate were meant to be private. If there is a need to use fileprivate in the future, it should be considered then. Not now.
    jjatie authored and liuxuan30 committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    8c9d5f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6faf53 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3078 from liuxuan30/2772

    for #2745. chart should be weak.
    liuxuan30 authored Dec 8, 2017
    Configuration menu
    Copy the full SHA
    2ff5cb5 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2017

  1. Fix a bug may cause infinite loop. (#3073)

    * Fix a bug may cause infinite loop.
    
    * Update BarLineChartViewBase.swift
    
    put nil check first seems better
    JyHu authored and liuxuan30 committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    6fee51c View commit details
    Browse the repository at this point in the history
  2. Minor logic cleanup (#3041)

    jjatie authored and liuxuan30 committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    d321093 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. Replaced ChartUtils.Math in favour of an extension on `FloatingPoin…

    …t` (#2993)
    
    * Replaced `ChartUtils.Math` in favour of an extension on `FloatingPoint`
    
    Increases readability, and in many cases removes a set of parentheses to ensure order of operations.
    
    * Moved `normalizedAngled` into `FloatingPoint` extension
    
    Improves readability
    
    * Fix after merge
    
    * Pulled latest master
    
    * Renamed deg2rad/rad2deg
    jjatie authored and liuxuan30 committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    159e0f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ab6706 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. The backing var is not necessary. (#3000)

    * The backing far is not necessary.
    
    Appears to have been a way to expose the var to obj-c like so many others in the framework.
    
    * Corrections for PR
    
    * Pulled master
    
    * count -> endIndex
    
    where appropriate
    
    * fix a typo ifnot -> if not
    
    Just find a typo ifnot -> if not
    
    * Removed redundant notifyDataSetChanged()
    jjatie authored and liuxuan30 committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    d4a3d4f View commit details
    Browse the repository at this point in the history
  2. for #3061

    revert animationUpdate() and animationEnd()
    not trigger crash if subclass does nothing
    liuxuan30 committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    f9a1456 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3098 from danielgindi/3061

    for #3061 fix animation crash
    liuxuan30 authored Dec 14, 2017
    Configuration menu
    Copy the full SHA
    f1acb2a View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. Removed methods and properties deprecated in 1.0 (#2996)

    * Removed methods and properties deprecated in 1.0
    
    * Removed old bridging functions
    
    These were only being used by deprecated methods.
    
    * Pulled latest master
    jjatie authored and liuxuan30 committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    ecdd295 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. Makes ChartsDemo compiling again (#3117)

    * Use example drawEntryLabelsEnabled instead of removed drawSliceTextEnabled
    
    * Use in example ILineChartDataSet.mode property instead of removed drawSteppedEnabled one
    valeriyvan authored and liuxuan30 committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    5639818 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2017

  1. Merge pull request #2998 from jjatie/minor-formatter-logic

    Minor changes to Formatter logic
    jjatie authored Dec 24, 2017
    Configuration menu
    Copy the full SHA
    8b18e76 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ef8aa1 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3002 from jjatie/equatable-fixed

    Resubmit of #2730
    jjatie authored Dec 24, 2017
    Configuration menu
    Copy the full SHA
    428843f View commit details
    Browse the repository at this point in the history