Add support for rounded corners for BarChart #3754

skarol · 2018-11-21T11:45:50Z

Issue Link 🔗

Rounding the corners of bars #1066

Goals ⚽

Add ability to draw rounded corners for BarChartView and HorizontalBarChartView.
Support also stacked bar charts.
Corner radius should be calculated automatically, depending on chart's width and height.
To use it simply add dataSet.roundedCorners = [.allCorners].

Implementation Details 🚧

Add roundedCorners property for BarChartDataSet, where you can specify which corners should be rounded.
Introduce changes in drawDataSet function in BarChartRenderer and HorizontalBarChartRenderer, where UIBezierPath is created to clip bar filling.
Similar changes apply to drawHighlighted function in BarChartRenderer.

Testing Details 🔍

Add testRoundedCorners test to BarChartTests.

liuxuan30 · 2018-12-04T02:33:58Z

except for CI errors, is problem solved for what I asked #1066 (comment) ?

skarol · 2018-12-04T08:29:21Z

@liuxuan30

CI errors occurred due to a slight difference in drawing bars approach. Look at the diffs. IMO it's not possible (without hacking - like massive if with old and new approach) to implement this feature and have CI passing.
Do you have bars thickness in mind? It should work for thin and fat bars as well.

liuxuan30 · 2018-12-11T01:48:38Z

@skarol I mean if the bars are thin enough, it becomes an oval more like a bar with rounded corners. That's what I said a flaw in #1066 (comment), and hold similar PRs till now. Have you solved this? (sorry I don't have time to download your PR and test it on my side so far)

If so, I could take a deep look and maybe we could fix the CI errors and get this merged.

skarol · 2018-12-11T15:43:49Z

@liuxuan30 yes, I've solved it. Basically, corner radius is half of bar's width for BarCharView and half of bar's height for HorizontalBarChart. For very thin bars it will look like this:

and for fat ones:

liuxuan30 · 2018-12-17T01:17:07Z

That's fantastic. we will take time for this. But maybe longer :(
have to take a look at CI errors first

liuxuan30 · 2018-12-24T02:19:08Z

@jjatie which branch do you think we should use to merge this PR? I'm asking because this is a nice feature that waited for too long (if it solves my questions), so I'm hoping to add them soon in master. But I'm seeing conflicts with 4.0 refactor.

liuxuan30 · 2018-12-24T02:26:15Z

Source/Charts/Renderers/BarChartRenderer.swift

@@ -377,9 +377,9 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer
        // draw the bar shadow before the values
        if dataProvider.isDrawBarShadowEnabled
        {
-            for j in stride(from: 0, to: buffer.rects.count, by: 1)
+            for firstIndexInBar in stride(from: 0, to: buffer.rects.count, by: 1)


why change name here? seems nothing about first index

I have the same question. If anything the change should be:

for barRect in buffer.rects where viewPortHandler.isInBoundsLeft(barRect.maxX) { guard viewPortHandler.isInBoundsRight(barRect.origin.x) else { break } context.setFillColor(dataSet.barShadowColor.cgColor) context.fill(barRect) }

liuxuan30 · 2018-12-24T02:28:12Z

Source/Charts/Renderers/BarChartRenderer.swift

@@ -896,4 +934,32 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer

        return element
    }
+
+    private func findTopRectInBar(barRects: [CGRect], firstIndexInBar: Int, lastIndexInBar: Int) -> CGRect {


let's put all { to another line. This is the code style for this library

liuxuan30 · 2018-12-24T02:29:32Z

Source/Charts/Renderers/HorizontalBarChartRenderer.swift

@@ -628,4 +655,31 @@ open class HorizontalBarChartRenderer: BarChartRenderer
    {
        high.setDraw(x: barRect.midY, y: barRect.origin.x + barRect.size.width)
    }
+
+    override internal func createBarPath(for rect: CGRect, roundedCorners: UIRectCorner) -> UIBezierPath {


could bar renderer and horizontal bar renderer share the same createBarPath and findMostLeftRectInBar somehow?

liuxuan30 · 2018-12-24T02:31:49Z

Tests/Charts/BarChartTests.swift

@@ -339,4 +339,12 @@ class BarChartTests: FBSnapshotTestCase
        chart.notifyDataSetChanged()
        FBSnapshotVerifyView(chart, identifier: Snapshot.identifier(UIScreen.main.bounds.size), tolerance: Snapshot.tolerance)
    }
+
+    func testRoundedCorners() {


not seeing updated images for testing rounded corners.

liuxuan30 · 2018-12-24T02:34:48Z

Source/Charts/Renderers/BarChartRenderer.swift

@@ -402,53 +402,81 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer
        {
            context.setFillColor(dataSet.color(atIndex: 0).cgColor)
        }
+
+        context.setStrokeColor(borderColor.cgColor)


it seems you are using drawBorder properties for rounded corners. Why force setting setLineCap(.square)?

But what if people disable drawBorder?

liuxuan30 · 2018-12-24T02:38:27Z

Source/Charts/Renderers/BarChartRenderer.swift


        // In case the chart is stacked, we need to accomodate individual bars within accessibilityOrdereredElements
        let isStacked = dataSet.isStacked
        let stackSize = isStacked ? dataSet.stackSize : 1

-        for j in stride(from: 0, to: buffer.rects.count, by: 1)
+        for firstIndexInBar in stride(from: 0, to: buffer.rects.count, by: stackSize)


why stackSize here?

Seems like it was done for the stacked bar char case, if round each bar when we will have this situation (from my rounding implementation).

Author's example:

Seems like it was done for the stacked bar char case, if round each bar when we will have this situation (from my rounding implementation).

Author's example:

That's exactly what I wanted to do. Round corner each bar with space in between. Do you have a demo project?

Hello @panncherry
You can check my fork/branch. Do not remember if bothered with an example adjustment as not going to upload a pull request, but the changes should be pretty straightforward to update existing StackedBarChar from the ChartsDemo-iOS

liuxuan30 · 2018-12-24T05:53:02Z

@skarol it seems CI failed because multiple bar chart tests failures. If rounded corner is turned on by default, then that's the reason. we need to have a switch to turn it off and add a new rounded bar test.

jjatie · 2018-12-25T04:25:19Z

Source/Charts/Renderers/BarChartRenderer.swift

@@ -377,9 +377,9 @@ open class BarChartRenderer: BarLineScatterCandleBubbleRenderer
        // draw the bar shadow before the values
        if dataProvider.isDrawBarShadowEnabled
        {
-            for j in stride(from: 0, to: buffer.rects.count, by: 1)
+            for firstIndexInBar in stride(from: 0, to: buffer.rects.count, by: 1)


I have the same question. If anything the change should be:

for barRect in buffer.rects where viewPortHandler.isInBoundsLeft(barRect.maxX) { guard viewPortHandler.isInBoundsRight(barRect.origin.x) else { break } context.setFillColor(dataSet.barShadowColor.cgColor) context.fill(barRect) }

jjatie · 2018-12-25T04:31:34Z

Source/Charts/Renderers/BarChartRenderer.swift

-            {
-                // Set the color for the currently drawn value. If the index is out of bounds, reuse colors.
-                context.setFillColor(dataSet.color(atIndex: j).cgColor)
+            for index in firstIndexInBar...lastIndexInBar {


let barRects = buffer.rects[firstIndexInBar...lastIndexInBar] for (index, rect) in zip(barRects, barRects.indices) where viewPortHandler.isInBoundsLeft(barRect.maxX) { ... }

jjatie · 2018-12-25T04:33:31Z

Source/Charts/Renderers/BarChartRenderer.swift

+        }
+
+        var height: CGFloat = 0
+        for index in firstIndexInBar...lastIndexInBar {


topRectInBar.size.height = barRects[firstIndexInBar...lastIndexInBar] .reduce(0) { $0 + $1.height }

jjatie · 2018-12-25T04:36:57Z

Source/Charts/Renderers/BarChartRenderer.swift

+    }
+
+    /// Creates path for bar in rect with rounded corners
+    internal func createBarPath(for rect: CGRect, roundedCorners: UIRectCorner) -> UIBezierPath {


internal is default and is not needed.

jjatie · 2018-12-25T05:01:53Z

@liuxuan30 I think we should start only targeting 4.0.0. Will encourage us to get it out faster and with more features in it, encourage people to update and help us keep it bug free.

samjarman · 2019-02-20T22:50:53Z

Any update on this @skarol? @liuxuan30? :)

liuxuan30 · 2019-03-04T01:36:47Z

not really.. have to postpone, working on 3.3 release and PRs

skarol · 2019-03-04T07:37:16Z

Sorry, have been busy lately :/ I'll try to address this soon

samjarman · 2019-03-05T01:51:46Z

One more question about this PR for @skarol and @liuxuan30 - the rounded corners seem to be perfectly semicircular - what about exposing the option to round corners with a given corner radius? This would be much more flexible and design agnostic. I'm guessing it is not really in the spirit of such a library to dictate design decisions like this? :)

skarol · 2019-03-05T06:37:17Z

@samjarman I decided to not expose corner radius and calculate it as a semicircular on a purpose. When creating a chart you have no idea about bars width and height so it is hard to pass good looking corner radius and semicircular always looks good :)

samjarman · 2019-03-05T21:45:34Z

Hmm, I thought it'd be possible for a developer to calculate their own corner radius (such as the one on these input fields and comments on github) based on the width of the bar?

If you can't get the width of the bar, maybe set a corner radius and then a minimum width for the corner radius to be used?

samjarman · 2019-03-05T21:46:09Z

I think "semicircular always looks good" is our designers decisions not really a framework's decision, y'know? :)

All changes taken from: ChartsOrg#3754

iDevid · 2019-04-24T07:42:05Z

Some news about this?

FrancescoTr · 2019-04-24T07:46:37Z

Really hoping to see this feature implemented

igorkulman · 2019-04-26T14:36:58Z

If the main problem is that it does not look "right" in some situations, why not add an additional parameter?

Something like

enum Radius {
    case none
    case widthPercentage(CGFLoat)
    case absolute(CGFLoat)
}

With .widthPercentage(50.0) matching the current implementation.

iDevid · 2019-05-23T08:50:51Z

Some news about this?

brunodalarosa · 2019-05-31T16:44:37Z

Looking forward to use this feature, any news? Thanks for the great work on this lib :D

denandreychuk · 2019-12-20T12:56:01Z

Can someone help me? I got Thread 1: EXC_BAD_ACCESS (code=1, address=0x0) on bar char init when tries to install using pods from this branch:

This one works:
pod 'Charts'

This one doesn't:
pod 'Charts', :git => 'https://github.com/danielgindi/Charts.git', :branch => 'roundedBars'

Anybody faced with this problem?
Seems like I should make some additional steps, because installing from master doesn't work too.

pod 'Charts', :git => 'https://github.com/danielgindi/Charts.git', :branch => 'master'

denandreychuk · 2019-12-27T10:55:23Z

Maybe it helps someone. To get this feature works, add these to your pod file:
pod 'Charts', :git => 'https://github.com/tooploox/Charts.git', :branch => 'feature/rounded-corners'

If you have the same crash as me, just reinstall Charts in pod file.

albertopeam · 2020-01-11T09:42:55Z

Source/Charts/Renderers/BarChartRenderer.swift

+
+        let cornerRadius = rect.width / 2.0
+
+        let path = UIBezierPath(roundedRect: rect,


@skarol I see a problem here when the rect is smaller than the cornerRadius, in this case you'll have a smashed rounded rectangle that looks bad(I haven't tested this code, but I worked in this feature in my fork, and at the start I had used the UIBezierPath like you with the result that I have commented, some screenshots at the end, apologies for the quality).
My proposal to solve this is to split it into two cases(Take into consideration that I haven't used the open var roundedCorners: UIRectCorner = []. I will always round all corners)

rect.height >= rect.width in this case we can perform the UIBezierPath as you do

rect.height < rect.width in this case we can draw a portion of a circumference, I leave the algorithm

let height = rect.size.height let hypotenuse = width / 2.0 let radius = hypotenuse let startAngle: CGFloat let endAngle: CGFloat if height < radius { let oLeg = radius - height startAngle = asin(oLeg/hypotenuse) endAngle = CGFloat(Double.pi) - startAngle } else { let oLeg = height - radius startAngle = -asin(oLeg/hypotenuse) endAngle = CGFloat(Double.pi) - startAngle } let y = rect.origin.y - (width - rect.size.height) let center = CGPoint(x: rect.origin.x + radius, y: y + radius) let bezierPath = UIBezierPath(arcCenter: center, radius: radius, startAngle: startAngle, endAngle: endAngle, clockwise: true)

Before

After

iDevid · 2020-01-23T14:55:32Z

why this was closed? @danielgindi

amit2908 · 2020-04-10T12:19:36Z

Rounded Rect seems an important requirement @danielgindi . Please reopen it and merge changes.

danielgindi · 2020-04-11T17:12:50Z

why this was closed? @danielgindi

Friends I can’t remember every PR but please read the history here. There are issues that weren’t addressed and there is another branch that does this.

liuxuan30 · 2020-04-15T03:10:22Z

@danielgindi it's weird our branch roundedBars is gone
But I do remember this PR, this is a new PR compared to an old one #1917 , this seems more promising, but the author seemed paused. I was planning to modify and merge it and I found out we have to solve the conflicts, and require feedback from him/her, but no reply yet

liuxuan30 · 2020-04-17T01:13:30Z

I will reopen this one as this seems the best rounded bar by far. The poblem is we need help from @skarol, or we take it from here.

pylapp · 2020-05-05T13:34:41Z

Hi!

Could you be nice to process this pull request?
It may be cool to have rounded corners for bars :)

Cheers

rubenmfdeveloper · 2020-05-12T07:25:14Z

Hi everyone!

There is something I could do to add the feature ASAP?
I really need this feature @skarol

Thanks,

Pearapps · 2020-05-22T07:11:38Z

I put up a PR that adds this functionality as well: #4375

No clue if it will get in (likely not, for similar reasons as this one) - but its a more up to date approach you can probably pull in / play with.

bivant · 2020-07-28T00:44:49Z

Hello.
I think that we need to agree on the functionality that rounding should support. Like corners (top, left...) and radius formula previous suggestion. Probably need to create separate class for the rounding parameters to not be across the several different parameters in the chart class.
Android conterpart seems like allow to achieve this by overriding the renderer
Radius
I suggest formula for the radius: widthFactor * barWidth / 2 + fixedRadiusValue
Obviously widthFactor should apply to the half of the bar as typical case is rounding bar edge. So it seems more intuitive to me that widthFactor == 1.0 leads to that result
This will allow:

specify rounding like the author meant - radius is half of a bar width (height if horizontal chart)
specify constant radius (the case I need)
any combination of above

Edge cases:

what to do when formula value exceeds half of the bar width (both parameters are set, bar too narrow to fit in the constant)? Use half of the width or respect fixedRadiusValue?
If fixedRadiusValue too big and factor is 0/ignored - lower radius to half of the width or set it to 0 so we see "regular" rectangular bar? The @liuxuan30 issue
too small value bar behavior suggestion Add support for rounded corners for BarChart #3754 (comment) . Is this a problem? Should it be configurable?

Corners
It seems like a nice to have control other this as the library should allow to customize the output as much as possible.
What about stacked bar then? Apply bottom corners for the bottom most part and top corners to the topmost one? Or add another parameter so each bar can have the rounding? Is this case real?

liuxuan30 · 2020-08-04T23:56:30Z

just FYI that we are actively working on the long waited 4.0 merge right now, so if anyone want to contribute on this one, wait until we merge 4.0.
It is a huge update with new features and more importantly, it's more swifty, so some APIs would need a change.

pratikgajbhiye222 · 2020-08-18T09:10:24Z

just FYI that we are actively working on the long waited 4.0 merge right now, so if anyone want to contribute on this one, wait until we merge 4.0.
It is a huge update with new features and more importantly, it's more swifty, so some APIs would need a change.

Can I use this function for rounded corner?

antondityativ · 2020-08-24T03:47:50Z

@liuxuan30 Could you say when this feature will be in the master branch?

liuxuan30 · 2020-10-12T11:23:17Z

nope, not any estimatable time. I mean it's a big change and the author seems not responding. Besides, we are having 4.0 branch merging ahead, and 4.0 branch is already big enough and will cause more code break for this PR. Without the author's help, I don't think we can merge this fairly.

bivant · 2020-12-14T12:23:46Z

Hello @liuxuan30
I am ready to dive in the rounding feature implementation in this PR or in my own in the next couple of weeks as master is 4.0 now. But need to decide which features should be supported first.

haswiniparmar1 · 2021-01-01T09:25:58Z

I want to give a corner radius to shadow in a bar chart view graph. How can I do this? @liuxuan30
Graph's highlight and the value filled portion has curve but the shadow has not. Please let me know if you have any solution for that.

charsdavy · 2023-08-18T08:29:21Z

why this was closed? @jjatie

Add support for rounded corners for BarChart

f53604a

alexeymax approved these changes Nov 29, 2018

View reviewed changes

Vyeczorny approved these changes Nov 30, 2018

View reviewed changes

liuxuan30 reviewed Dec 24, 2018

View reviewed changes

jjatie requested changes Dec 25, 2018

View reviewed changes

tastysauce added a commit to life360/Charts that referenced this pull request Mar 7, 2019

Adds support for rounded corners in bar charts

c38b016

All changes taken from: ChartsOrg#3754

tastysauce mentioned this pull request Mar 7, 2019

Adds support for rounded corners in bar charts life360/Charts#1

Merged

jjatie mentioned this pull request Mar 9, 2019

Add rounded corners on the bar chart #1066 #1917

Closed

igorkulman mentioned this pull request May 4, 2019

Second to last value in stacked BarChart not drawn when the last value is zero #3984

Closed

1 task

albertopeam reviewed Jan 11, 2020

View reviewed changes

danielgindi closed this Jan 23, 2020

liuxuan30 mentioned this pull request Apr 17, 2020

Rounded bars #4339

Closed

2 tasks

liuxuan30 reopened this Apr 17, 2020

Pearapps mentioned this pull request May 22, 2020

Rounded bars in bar charts #4375

Open

This was referenced Jun 12, 2020

Merge rounded corner radius mickamy/Charts#1

Merged

Add support for rounded corners for BarChart #4395

Closed

Add support for rounded corners for BarChar wealthnavi/Charts#1

Merged

bivant mentioned this pull request Dec 15, 2020

Update the renderers with dedicated atomic rendering methods in order to make rendering overrides easier to implement. #4297

Closed

jjatie closed this Jan 26, 2021

jjatie deleted the branch ChartsOrg:roundedBars January 26, 2021 13:08

4np mentioned this pull request Jan 29, 2021

Review / merge PR #4297 #4569

Open


		let cornerRadius = rect.width / 2.0

		let path = UIBezierPath(roundedRect: rect,

Add support for rounded corners for BarChart #3754

Add support for rounded corners for BarChart #3754

Conversation

skarol commented Nov 21, 2018

Issue Link 🔗

Goals ⚽

Implementation Details 🚧

Testing Details 🔍

liuxuan30 commented Dec 4, 2018 • edited Loading

skarol commented Dec 4, 2018

liuxuan30 commented Dec 11, 2018 • edited Loading

skarol commented Dec 11, 2018

liuxuan30 commented Dec 17, 2018

liuxuan30 commented Dec 24, 2018 • edited Loading

Choose a reason for hiding this comment

jjatie Dec 25, 2018 • edited Loading

Choose a reason for hiding this comment

liuxuan30 Dec 24, 2018 • edited by jjatie Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuxuan30 commented Dec 24, 2018 • edited Loading

jjatie Dec 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjatie commented Dec 25, 2018

samjarman commented Feb 20, 2019

liuxuan30 commented Mar 4, 2019

skarol commented Mar 4, 2019

samjarman commented Mar 5, 2019 • edited Loading

skarol commented Mar 5, 2019

samjarman commented Mar 5, 2019

samjarman commented Mar 5, 2019

iDevid commented Apr 24, 2019

FrancescoTr commented Apr 24, 2019

igorkulman commented Apr 26, 2019

iDevid commented May 23, 2019

brunodalarosa commented May 31, 2019

denandreychuk commented Dec 20, 2019

denandreychuk commented Dec 27, 2019

Choose a reason for hiding this comment

iDevid commented Jan 23, 2020

amit2908 commented Apr 10, 2020

danielgindi commented Apr 11, 2020

liuxuan30 commented Apr 15, 2020 • edited Loading

liuxuan30 commented Apr 17, 2020

pylapp commented May 5, 2020

rubenmfdeveloper commented May 12, 2020

Pearapps commented May 22, 2020

bivant commented Jul 28, 2020 • edited Loading

liuxuan30 commented Aug 4, 2020

pratikgajbhiye222 commented Aug 18, 2020

antondityativ commented Aug 24, 2020

liuxuan30 commented Oct 12, 2020

bivant commented Dec 14, 2020

haswiniparmar1 commented Jan 1, 2021

charsdavy commented Aug 18, 2023

liuxuan30 commented Dec 4, 2018 •

edited

Loading

liuxuan30 commented Dec 11, 2018 •

edited

Loading

liuxuan30 commented Dec 24, 2018 •

edited

Loading

jjatie Dec 25, 2018 •

edited

Loading

liuxuan30 Dec 24, 2018 •

edited by jjatie

Loading

liuxuan30 commented Dec 24, 2018 •

edited

Loading

jjatie Dec 25, 2018 •

edited

Loading

samjarman commented Mar 5, 2019 •

edited

Loading

liuxuan30 commented Apr 15, 2020 •

edited

Loading

bivant commented Jul 28, 2020 •

edited

Loading