-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library name #5009
Update library name #5009
Conversation
Thanks for your contritution! this is what we exactly needed! however, UIChart seems unpossible since it's reserved by Apple already. Would mind change to DGCharts ? |
let's make sure it biuld on xcode 14 as well |
Shouldn't the directory names also be updated from |
Wow, yep that was a big mistake on my part - updated. |
I have also built and run this in a personal app targeting my fork and branch - on Xcode 14.2 |
What about the |
I am taking a look at why the snapshot test resources were removed. That was not intentional |
I am looking at this today and I do not think we need to rename all the source files. We can just change the product name. I will take some of these changes but leave the code reorg to the side. It will make maintainability easier for us to not reorg everything. |
Closed by #5027 |
Issue Link #4845
Fixes naming conflict with Apple's Charts framework
Goals ⚽
Update the Swift package name
Update the podspec
Update the directory structure to match
Update the Charts xcode project to use a folder-based structure instead of Groups
Implementation Details 🚧
Implemented each step in a single commit so it's easier to follow
Testing Details 🔍