Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Release/5.0.0 #5028

Merged
merged 25 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f48597f
fixed no used warning
eren-celik Jun 15, 2022
5be8cde
Turn on the BUILD_LIBRARY_FOR_DISTRIBUTION flag
matopeto Sep 14, 2022
6dd7687
Update README.md
stepanovgena Nov 15, 2022
0c194fa
Change library name from Charts to DGCharts
pmairoldi Mar 11, 2023
f9bbde9
Merge pull request #5027 from danielgindi/chanage-library-name
pmairoldi Mar 21, 2023
c007e85
update workflow to run on release branches
pmairoldi Mar 21, 2023
ace0feb
update readme to change name
pmairoldi Mar 21, 2023
b43d7a6
Merge pull request #4971 from stepanovgena/master
pmairoldi Mar 21, 2023
e392e19
Merge pull request #4841 from eren-celik/fix/warning
pmairoldi Mar 21, 2023
9f9aac4
add discardable results to operations that do not require result
pmairoldi Mar 21, 2023
2f9ccf7
Merge pull request #4912 from matopeto/feature/build_library_for_dist…
pmairoldi Mar 21, 2023
71ea447
Fix Xcode 14.3 import warnings
FelixHerrmann Apr 9, 2023
44d3bdc
bump min version to 13 for ios project
May 25, 2023
33c4c99
undo framework bump
May 30, 2023
158cdb6
update tvos
May 30, 2023
95ea918
Merge pull request #5062 from waterskier2007/update-min-version
pmairoldi Jun 2, 2023
310f4be
Merge pull request #5067 from danielgindi/master
pmairoldi Jun 7, 2023
56b4f22
Merge pull request #5041 from FelixHerrmann/master
pmairoldi Jun 8, 2023
51468ce
fix #5033: always run snapshot tests in light mode
pmairoldi Jun 8, 2023
796f785
remove swift-algorithms package in favor of manully importing needed …
pmairoldi Jun 8, 2023
3cf3256
Merge pull request #5069 from danielgindi/fix/remove-swift-algorithms
pmairoldi Jun 8, 2023
50c408b
fix build issue
pmairoldi Jun 8, 2023
b60d833
update readme versions
pmairoldi Jun 8, 2023
3d5b031
update ci
pmairoldi Jun 8, 2023
284a778
Merge pull request #5070 from danielgindi/update-actions
pmairoldi Jun 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@

ℹ Please replace this with of what happened instead.

## Charts Environment
## DGCharts Environment

**Charts version/Branch/Commit Number:**
**DGCharts version/Branch/Commit Number:**
**Xcode version:**
**Swift version:**
**Platform(s) running Charts:**
**Platform(s) running DGCharts:**
**macOS version running Xcode:**

## Demo Project
Expand Down
70 changes: 43 additions & 27 deletions .github/workflows/swift.yml
Original file line number Diff line number Diff line change
@@ -1,65 +1,81 @@
name: Swift

on:
workflow_dispatch:
push:
branches:
- master
- "*"
pull_request:
branches:
- "*"

concurrency:
group: ${{ github.ref }}
cancel-in-progress: true

jobs:
iOS:
buildFramework:
name: Build framework
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.2.app/Contents/Developer
strategy:
matrix:
destination: ["OS=16.0,name=iPhone 14 Pro"] #, "OS=14.4,name=iPhone 12 Pro", "OS=12.4,name=iPhone XS", "OS=11.4,name=iPhone X", "OS=10.3.1,name=iPhone SE"]
target:
- destination: "OS=16.2,name=iPhone 14 Pro"
actions: "build test"
- destination: "OS=16.1,name=Apple TV 4K (3rd generation)"
actions: "build test"
- destination: "platform=macOS"
actions: "build"
steps:
- uses: actions/checkout@v3
- name: iOS - ${{ matrix.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "Charts" -destination "${{ matrix.destination }}" clean test | xcpretty
- name: Build framework - ${{ matrix.target.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "DGCharts" -destination "${{ matrix.target.destination }}" clean ${{ matrix.target.actions }} | xcpretty

tvOS:
buildDemo:
name: Build demo
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.2.app/Contents/Developer
strategy:
matrix:
destination: ["OS=16.0,name=Apple TV 4K (2nd generation)"]
target:
- scheme: "ChartsDemo-iOS"
destination: "OS=16.2,name=iPhone 14 Pro"
- scheme: "ChartsDemo-macOS"
destination: "platform=macOS"
steps:
- uses: actions/checkout@v3
- name: tvOS - ${{ matrix.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "Charts" -destination "${{ matrix.destination }}" clean test | xcpretty
- name: Build demo - ${{ matrix.target.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "${{ matrix.target.scheme }}" -destination "${{ matrix.target.destination }}" clean build | xcpretty

macOS_demo:
spm:
name: Test with SPM
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.2.app/Contents/Developer
steps:
- uses: actions/checkout@v3
- name: macOS
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "ChartsDemo-macOS" -destination "platform=macOS" clean build | xcpretty
- name: SPM Test
run: swift build

iOS_demo:
carthage:
name: Test with carthage
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
strategy:
matrix:
destination: ["OS=16.0,name=iPhone 14 Pro"] #, "OS=14.4,name=iPhone 12 Pro", "OS=12.4,name=iPhone XS", "OS=11.4,name=iPhone X", "OS=10.3.1,name=iPhone SE"]
DEVELOPER_DIR: /Applications/Xcode_14.2.app/Contents/Developer
steps:
- uses: actions/checkout@v3
- name: iOS - ${{ matrix.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "ChartsDemo-iOS" -destination "${{ matrix.destination }}" clean build | xcpretty
- name: Carthage Test
run: carthage build --use-xcframeworks --no-skip-current

spm:
name: Test with SPM
cocoapods:
name: Test with cocoapods
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.2.app/Contents/Developer
steps:
- uses: actions/checkout@v3
- name: SPM Test
run: swift build -c debug
- name: Carthage Test
run: pod lib lint
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,5 @@ fastlane/Preview.html
fastlane/screenshots
fastlane/test_output
Carthage
Charts.framework.zip
ChartsRealm.framework.zip
DGCharts.framework.zip
.swiftpm/
38 changes: 19 additions & 19 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
# How to contribute

Bug-fixes and features often come from users of the Charts framework, and improving it greatly. We want to keep it as easy as possible to contribute changes that improve the experience for users all around the world. There are a few guidelines that we
Bug-fixes and features often come from users of the DGCharts framework, and improving it greatly. We want to keep it as easy as possible to contribute changes that improve the experience for users all around the world. There are a few guidelines that we
need contributors to follow so that we can have a chance of keeping on
top of things.

## Simple issues and bug reports

If you are reporting a bug which can be observed visually, please add to your issue either:

* Screenshots, if the bug is easily explainable
* A working sample project that we can compile, run, and immediately observe the issue
- Screenshots, if the bug is easily explainable
- A working sample project that we can compile, run, and immediately observe the issue

## Getting Started with Contributions

* Make sure you have a [GitHub account](https://github.com/signup/free)
* Submit a ticket for your issue, assuming one does not already exist.
* Clearly describe the issue including steps to reproduce when it is a bug.
* Make sure you fill in the earliest version (or commit number) that you know has the issue.
* Fork the repository on GitHub
- Make sure you have a [GitHub account](https://github.com/signup/free)
- Submit a ticket for your issue, assuming one does not already exist.
- Clearly describe the issue including steps to reproduce when it is a bug.
- Make sure you fill in the earliest version (or commit number) that you know has the issue.
- Fork the repository on GitHub

## Making Changes

* Create a topic branch from where you want to base your work. This is usually the master branch.
* Make commits of logical units.
* Make sure your code conforms to the code style around it. It's easy, just look around!
* If you have made changes back and forth, or have made merges, your commit history might look messy and hard to understand. A single issue or change should still be in one commit. So please squash those commits together and rebase them however you need to - to make our lives easier when reading it later.
* Check for unnecessary whitespace with `git diff --check` before committing.
* Make sure your commit messages are in the proper format.
- Create a topic branch from where you want to base your work. This is usually the master branch.
- Make commits of logical units.
- Make sure your code conforms to the code style around it. It's easy, just look around!
- If you have made changes back and forth, or have made merges, your commit history might look messy and hard to understand. A single issue or change should still be in one commit. So please squash those commits together and rebase them however you need to - to make our lives easier when reading it later.
- Check for unnecessary whitespace with `git diff --check` before committing.
- Make sure your commit messages are in the proper format.

````
```
First line must be up to 50 chars (Fixes #1234)

The first line should be a short statement as to what have changed, and should also include an issue number, prefixed with a hash.
The body of the message comes after an empty new line, and describes the changes
more thoroughly, especially if there was a special case handled there,
or maybe some trickery that only code wizards can understand.
````
```

* Make sure you have tested your changes well.
* If your changes could theoretically affect some other component or case, which you do not necessarily use, you still have to test it.
* Create a Pull Request from your topic branch to the relevant branch in the main repo. If you go to the main repo of the framework, you'll see a big green button which pretty much prepares the PR for you. You just have to hit it.
- Make sure you have tested your changes well.
- If your changes could theoretically affect some other component or case, which you do not necessarily use, you still have to test it.
- Create a Pull Request from your topic branch to the relevant branch in the main repo. If you go to the main repo of the framework, you'll see a big green button which pretty much prepares the PR for you. You just have to hit it.

## Making Trivial Changes

Expand Down
Loading