Fixed label drawing bug #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the Y-Axis labels where disappearing when no data was displayed in the LineChart. This could happen, for example, if all currently visible data entries where nil. ** I am not that familiar with all this CGContext stuff and find it vey strange, that not calling a method in one renderer (LineChartRenderer) has an affect on an other renderer (AxisYRenderer), but maybe someone can explain and/or find a better solution then this one **
|
Turned out this issue was caused by the LineChartsRenders drawLiniar method. This method saved the context but didn't release it when returning from the method earlier because of missing entries. |
|
Is there an issue id to track this? Or screenshot? I don't understand the problem. |
|
Are you sure this fixes anything? Seems like a push/pop for nothing, as we change nothing on the context... |
|
It did fix it in my special case, but I think the better fix would be to change the LineChartRenderer. I'll submit a PR for this soon. The problem is that the LineChartRenderer doesn't restore the context when not displaying any data (only in drawLiniar). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the Y-Axis labels where disappearing when no data was
displayed in the LineChart.
This could happen, for example, if all currently visible data entries
where nil.
** I am not that familiar with all this CGContext stuff and find it vey
strange, that not calling a method in one renderer (LineChartRenderer)
has an affect on an other renderer (AxisYRenderer), but maybe someone
can explain and/or find a better solution then this one **