-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace '&' with concurrently for cross-platform compatibility #5126
Conversation
Someone is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent updates to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- package.json (2 hunks)
Additional comments not posted (5)
package.json (5)
7-7
: Approved:mask:watch
script is correctly formatted and functional.The
mask:watch
script usesnpx watch "yarn mask" app/masks
and is correctly formatted. This script is crucial for the newconcurrently
scripts.
8-8
: Approved:dev
script is correctly formatted and functional.The
dev
script usesconcurrently -r "yarn run mask:watch" "next dev"
, ensuring cross-platform compatibility.
13-13
: Approved:export:dev
script is correctly formatted and functional.The
export:dev
script usesconcurrently -r "yarn mask:watch" "cross-env BUILD_MODE=export BUILD_APP=1 next dev"
, ensuring cross-platform compatibility.
14-14
: Approved:app:dev
script is correctly formatted and functional.The
app:dev
script usesconcurrently -r "yarn mask:watch" "yarn tauri dev"
, ensuring cross-platform compatibility.
56-56
: Approved:concurrently
added as a devDependency.The
concurrently
package has been added as a devDependency with version^8.2.2
, ensuring it is available for the scripts that require it.
Your build has completed! |
- Used `concurrently` to run parallel commands in package.json scripts - Added `concurrently` as a devDependency in package.json
edda50e
to
04a4e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- package.json
Fixed #5125
π» εζ΄η±»ε | Change Type
π εζ΄θ―΄ζ | Description of Change
concurrently
to run parallel commands in package.json scriptsconcurrently
as a devDependency in package.jsonOn Windows
On Linux
π θ‘₯ε δΏ‘ζ― | Additional Information
Summary by CodeRabbit
New Features
concurrently
package to improve the execution of multiple commands in parallel, enhancing the development workflow.Chores
package.json
for better readability and reliability in managing concurrent tasks.