-
Notifications
You must be signed in to change notification settings - Fork 59.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 代码块嵌入小代码块时渲染错误 #5827
fix: 代码块嵌入小代码块时渲染错误 #5827
Conversation
@OPChips is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request introduces a modification to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/components/markdown.tsx (1)
251-254
: Consider a more precise implementation for detecting embedded code blocks.While the current implementation fixes the rendering issue, the condition
text.includes("```")
might be too broad. It will skip processing any text that contains triple backticks, even if the HTML code itself is not within a code block.Consider using a more precise check:
- if (text.includes("```")) { + // Check if the HTML code is already within a code block + const codeBlockRegex = /^```[\s\S]*?<!DOCTYPE html>[\s\S]*?```$/m; + if (codeBlockRegex.test(text)) { return text; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
app/components/markdown.tsx
(1 hunks)
🔇 Additional comments (1)
app/components/markdown.tsx (1)
251-254
: Verify the fix resolves the original issue.
Let's verify this change fixes the rendering error described in issue #5797.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information
#5797
before:
after:
Summary by CodeRabbit
New Features
Bug Fixes