Exclude /results from channel resolver (#616)

* Exclude /results from channel resolver * Add changelog entry
Chatterino · Apr 3, 2024 · 9b8acaa · 9b8acaa
1 parent d43279b
commit 9b8acaa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased
 
 - Minor: Add playlist support to YouTube resolver. (#597, #601)
+- Fix: Do not resolve /results using YouTube channel resolver (#616)
 
 ## 2.0.3
 

diff --git a/internal/resolvers/youtube/channel_resolver.go b/internal/resolvers/youtube/channel_resolver.go
@@ -26,6 +26,10 @@ func (r *YouTubeChannelResolver) Check(ctx context.Context, url *url.URL) (conte
 		return ctx, false
 	}
 
+	if url.Path == "/results" {
+		return ctx, false
+	}
+
 	q := url.Query()
 	// TODO(go1.18): Replace with q.Has("v") once we've transitioned to at least go 1.17 as least supported version
 	if q.Has("v") {

diff --git a/internal/resolvers/youtube/channel_resolver_test.go b/internal/resolvers/youtube/channel_resolver_test.go
@@ -140,6 +140,11 @@ func TestChannelResolver(t *testing.T) {
 				input:    utils.MustParseURL("https://youtube.com"),
 				expected: false,
 			},
+			{
+				label:    "Correct domain, results path",
+				input:    utils.MustParseURL("https://youtube.com/results?search_query=test"),
+				expected: false,
+			},
 			{
 				label:    "Incorrect domain",
 				input:    utils.MustParseURL("https://example.com/watch?v=foobar"),