Migrate Twitch clips to Helix API #144
Merged
+147
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:tf: cvHazmat 🤏
resolving before we have an app access token
pajlada
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
We deprecated usage of dankeroni/gotwitch in favour of nicklaw5/helix.
Our strategy of managing app access token (which is required for Helix calls we use) is the following: request and set it upon custom handler initialization and then re-request it every 24 hours.
Breaking change:
We now require client secret for creating app access tokens - new env variable:
CHATTERINO_API_TWITCH_CLIENT_SECRETRenamed client id env variable for more consistency (
CHATTERINO_API_CACHE_TWITCH_CLIENT_ID=>CHATTERINO_API_TWITCH_CLIENT_ID).