Add support for clips from m.twitch.tv domain
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
approved these changes
Dec 11, 2021
Felanbird
approved these changes
Dec 11, 2021
|
I dislike how invalid links can be seen as valid in new regex (e.g. |
While attempting to change regex a bit I managed to come across this being seen as a valid Twitch clip link. While I decided to not go with my changes I think it's wise to keep the test case.
|
Never mind the comment above, I spent 2 days on trying to over-engineer your regex pajlada and it added even more mess than it's worth it. I'm going to just merge this in instead. |
…de-mtwitchtv-in-twitchclip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Closes #230