Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement imgur.io resolving #365

Merged
merged 11 commits into from
Oct 22, 2022
Merged

implement imgur.io resolving #365

merged 11 commits into from
Oct 22, 2022

Conversation

gempir
Copy link
Contributor

@gempir gempir commented Oct 3, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Allow imgur.io to urls to be resolved as per #361

Most of the work done by @leon-richardt of sending a PR to our go imgur client.

@gempir gempir changed the title implement imgur resolving, a lot of nil pointer references, can't qui… implement imgur.io resolving Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #365 (83ad37f) into master (2c39e99) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   45.34%   45.38%   +0.03%     
==========================================
  Files         100      100              
  Lines        3670     3680      +10     
==========================================
+ Hits         1664     1670       +6     
- Misses       1959     1962       +3     
- Partials       47       48       +1     
Impacted Files Coverage Δ
internal/logger/context.go 0.00% <0.00%> (ø)
internal/resolvers/imgur/resolver.go 89.28% <70.00%> (-10.72%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Leon Richardt <git@leon.dev>
@leon-richardt
Copy link
Contributor

leon-richardt commented Oct 20, 2022

koffeinsource/go-imgur#16 has been merged upstream and is included in the v0.4.1 release.
@gempir, if you rebase your branch on master and bump the version in go.mod, it should Just Work:tm:

@gempir gempir marked this pull request as ready for review October 20, 2022 17:06
CHANGELOG.md Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) October 22, 2022 10:25
@pajlada pajlada merged commit 970c8c4 into Chatterino:master Oct 22, 2022
@gempir gempir deleted the imgurio branch October 22, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants