-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement imgur.io resolving #365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te figure out yet why
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 45.34% 45.38% +0.03%
==========================================
Files 100 100
Lines 3670 3680 +10
==========================================
+ Hits 1664 1670 +6
- Misses 1959 1962 +3
- Partials 47 48 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Leon Richardt <git@leon.dev>
koffeinsource/go-imgur#16 has been merged upstream and is included in the |
pajlada
requested changes
Oct 22, 2022
pajlada
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Allow imgur.io to urls to be resolved as per #361
Most of the work done by @leon-richardt of sending a PR to our go imgur client.