Skip to content

Set Version in User-Agent #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

M4tthewDE
Copy link
Contributor

@M4tthewDE M4tthewDE commented Apr 4, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Set current version in User-Agent

Closes #458

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #459 (7648c22) into master (8dfebc7) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 7648c22 differs from pull request most recent head b4096ca. Consider uploading reports for the commit b4096ca to get more accurate results

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   45.46%   45.45%   -0.02%     
==========================================
  Files         103      103              
  Lines        3818     3819       +1     
==========================================
  Hits         1736     1736              
- Misses       2032     2033       +1     
  Partials       50       50              
Impacted Files Coverage Δ
pkg/resolver/request.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise looks good 👍

@M4tthewDE M4tthewDE requested a review from pajlada April 4, 2023 16:44
@pajlada pajlada enabled auto-merge (squash) April 4, 2023 17:35
@pajlada pajlada merged commit 3ba49f3 into Chatterino:master Apr 4, 2023
@M4tthewDE M4tthewDE deleted the fix/include-version-in-user-agent branch April 4, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include actual version in the user agent in network requests we send
2 participants